[test] Fix test status file simulator_run not evaluate to boolean error and clean up equal operator

[test] Fix test status file simulator_run not evaluate to boolean error
and clean up equal operator

BUG=
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com, machenbach@chromium.org, rossberg@chromium.org

Review-Url: https://codereview.chromium.org/2961873002
Cr-Commit-Position: refs/heads/master@{#46301}
Committed: https://chromium.googlesource.com/v8/v8/+/e4753d282895df3d4a5cb0a2edb938ab836f09e4

[Sampson, 2017-06-27 19:23:36]

Please take a look.

[Michael Achenbach, 2017-06-28 06:42:36]

https://codereview.chromium.org/2961873002/diff/1/test/wasm-spec-tests/wasm-s...
File test/wasm-spec-tests/wasm-spec-tests.status (right):

https://codereview.chromium.org/2961873002/diff/1/test/wasm-spec-tests/wasm-s...
test/wasm-spec-tests/wasm-spec-tests.status:9: 'tests/skip-stack-guard-page':
[PASS, ['arch == mipsel or arch == mips64el or arch == x64 or arch == ia32 or
((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and
simulator_run == True)', SKIP]],
Are you sure this fixes it?
https://cs.chromium.org/chromium/src/v8/tools/run-tests.py?dr&q=simulator_run...
looks pretty much like a boolen expression.

I tried to debug the test runner locally to check the outcome, but couldn't
repro. Do you have a link to a failing bot or a step by step repro?

I didn't find this test case failing on any of our ppc/s390 simulator bots.

[Sampson, 2017-06-28 14:38:22]

On 2017/06/28 06:42:36, Michael Achenbach wrote:
>
https://codereview.chromium.org/2961873002/diff/1/test/wasm-spec-tests/wasm-s...
> File test/wasm-spec-tests/wasm-spec-tests.status (right):
> 
>
https://codereview.chromium.org/2961873002/diff/1/test/wasm-spec-tests/wasm-s...
> test/wasm-spec-tests/wasm-spec-tests.status:9: 'tests/skip-stack-guard-page':
> [PASS, ['arch == mipsel or arch == mips64el or arch == x64 or arch == ia32 or
> ((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and
> simulator_run == True)', SKIP]],
> Are you sure this fixes it?
>
https://cs.chromium.org/chromium/src/v8/tools/run-tests.py?dr&q=simulator_run...
> looks pretty much like a boolen expression.
> 
> I tried to debug the test runner locally to check the outcome, but couldn't
> repro. Do you have a link to a failing bot or a step by step repro?
> 
> I didn't find this test case failing on any of our ppc/s390 simulator bots.

It is not failing on simulator build, but on native it complains about the
expression evaluate to 'None'. So I look at other status file and see they all
use "simulator_run == True"

[Michael Achenbach, 2017-06-28 17:13:07]

On 2017/06/28 14:38:22, Sampson wrote:
> On 2017/06/28 06:42:36, Michael Achenbach wrote:
> >
>
https://codereview.chromium.org/2961873002/diff/1/test/wasm-spec-tests/wasm-s...
> > File test/wasm-spec-tests/wasm-spec-tests.status (right):
> > 
> >
>
https://codereview.chromium.org/2961873002/diff/1/test/wasm-spec-tests/wasm-s...
> > test/wasm-spec-tests/wasm-spec-tests.status:9:
'tests/skip-stack-guard-page':
> > [PASS, ['arch == mipsel or arch == mips64el or arch == x64 or arch == ia32
or
> > ((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and
> > simulator_run == True)', SKIP]],
> > Are you sure this fixes it?
> >
>
https://cs.chromium.org/chromium/src/v8/tools/run-tests.py?dr&q=simulator_run...
> > looks pretty much like a boolen expression.
> > 
> > I tried to debug the test runner locally to check the outcome, but couldn't
> > repro. Do you have a link to a failing bot or a step by step repro?
> > 
> > I didn't find this test case failing on any of our ppc/s390 simulator bots.
> 
> It is not failing on simulator build, but on native it complains about the
> expression evaluate to 'None'. So I look at other status file and see they all
> use "simulator_run == True"

Got it. When ARCH_GUESS is None, the whole expression evaluates to None. Could
you instead of your current fix put a bool() conversion around
https://cs.chromium.org/chromium/src/v8/tools/run-tests.py?dr&q=simulator_run...
? This is more elegant as it will ensure it always is True or False.

[Sampson, 2017-06-28 20:06:47]

Update as Michael suggested, please take a look.

[Michael Achenbach, 2017-06-28 20:41:52]

lgtm with comment:

https://codereview.chromium.org/2961873002/diff/20001/test/wasm-spec-tests/wa...
File test/wasm-spec-tests/wasm-spec-tests.status (right):

https://codereview.chromium.org/2961873002/diff/20001/test/wasm-spec-tests/wa...
test/wasm-spec-tests/wasm-spec-tests.status:9: 'tests/skip-stack-guard-page':
[PASS, ['arch == mipsel or arch == mips64el or arch == x64 or arch == ia32 or
((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and
simulator_run == True)', SKIP]],
Now the comparison with True shouldn't be necessary. If it isn't, please drop
it.

[Sampson, 2017-06-28 20:44:41]

On 2017/06/28 20:41:52, Michael Achenbach wrote:
> lgtm with comment:
> 
>
https://codereview.chromium.org/2961873002/diff/20001/test/wasm-spec-tests/wa...
> File test/wasm-spec-tests/wasm-spec-tests.status (right):
> 
>
https://codereview.chromium.org/2961873002/diff/20001/test/wasm-spec-tests/wa...
> test/wasm-spec-tests/wasm-spec-tests.status:9: 'tests/skip-stack-guard-page':
> [PASS, ['arch == mipsel or arch == mips64el or arch == x64 or arch == ia32 or
> ((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and
> simulator_run == True)', SKIP]],
> Now the comparison with True shouldn't be necessary. If it isn't, please drop
> it.

Then I think I should also drop this comparison for other status files, right?

[Michael Achenbach, 2017-06-28 20:46:21]

On 2017/06/28 20:44:41, Sampson wrote:
> On 2017/06/28 20:41:52, Michael Achenbach wrote:
> > lgtm with comment:
> > 
> >
>
https://codereview.chromium.org/2961873002/diff/20001/test/wasm-spec-tests/wa...
> > File test/wasm-spec-tests/wasm-spec-tests.status (right):
> > 
> >
>
https://codereview.chromium.org/2961873002/diff/20001/test/wasm-spec-tests/wa...
> > test/wasm-spec-tests/wasm-spec-tests.status:9:
'tests/skip-stack-guard-page':
> > [PASS, ['arch == mipsel or arch == mips64el or arch == x64 or arch == ia32
or
> > ((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and
> > simulator_run == True)', SKIP]],
> > Now the comparison with True shouldn't be necessary. If it isn't, please
drop
> > it.
> 
> Then I think I should also drop this comparison for other status files, right?

If you like, sure. Otherwise I'd have done it in a separate clean-up.

[Sampson, 2017-06-28 21:04:18]

Description was changed from

==========
PPC/S390: [test] Fix wasm-spec-test.status expression not evaluate to boolean
error

BUG=
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com,
machenbach@chromium.org, rossberg@chromium.org
==========

to

==========
[test] Fix test status file simulator_run not evaluate to boolean error
and clean up equal operator

BUG=
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com,
machenbach@chromium.org, rossberg@chromium.org
==========

[Sampson, 2017-06-28 21:04:32]

The CQ bit was checked by sampsong@ca.ibm.com

[Sampson, 2017-06-28 21:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2961873002/#ps40001
(title: "Drop unnecessary comparison operators")

[commit-bot: I haz the power, 2017-06-28 21:04:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 21:32:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498683872607120,
"parent_rev": "040fa06fb3dd1c2b32b99a47e927c7a69e2d62e0", "commit_rev":
"e4753d282895df3d4a5cb0a2edb938ab836f09e4"}

[commit-bot: I haz the power, 2017-06-28 21:32:33]

Description was changed from

==========
[test] Fix test status file simulator_run not evaluate to boolean error
and clean up equal operator

BUG=
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com,
machenbach@chromium.org, rossberg@chromium.org
==========

to

==========
[test] Fix test status file simulator_run not evaluate to boolean error
and clean up equal operator

BUG=
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com,
machenbach@chromium.org, rossberg@chromium.org

Review-Url: https://codereview.chromium.org/2961873002
Cr-Commit-Position: refs/heads/master@{#46301}
Committed:
https://chromium.googlesource.com/v8/v8/+/e4753d282895df3d4a5cb0a2edb938ab836...
==========

[commit-bot: I haz the power, 2017-06-28 21:32:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/e4753d282895df3d4a5cb0a2edb938ab836...

[Michael Achenbach, 2017-06-29 06:35:24]

lgtm, thanks for the clean up! Now it's much more pythonic :)