Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: tools/run-tests.py

Issue 2961873002: [test] Fix test status file simulator_run not evaluate to boolean error and clean up equal operator (Closed)
Patch Set: Drop unnecessary comparison operators Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/webkit/webkit.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 766 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 options.no_harness, 777 options.no_harness,
778 use_perf_data=not options.swarming, 778 use_perf_data=not options.swarming,
779 sancov_dir=options.sancov_dir) 779 sancov_dir=options.sancov_dir)
780 780
781 # TODO(all): Combine "simulator" and "simulator_run". 781 # TODO(all): Combine "simulator" and "simulator_run".
782 # TODO(machenbach): In GN we can derive simulator run from 782 # TODO(machenbach): In GN we can derive simulator run from
783 # target_arch != v8_target_arch in the dumped build config. 783 # target_arch != v8_target_arch in the dumped build config.
784 simulator_run = not options.dont_skip_simulator_slow_tests and \ 784 simulator_run = not options.dont_skip_simulator_slow_tests and \
785 arch in ['arm64', 'arm', 'mipsel', 'mips', 'mips64', 'mips64el', \ 785 arch in ['arm64', 'arm', 'mipsel', 'mips', 'mips64', 'mips64el', \
786 'ppc', 'ppc64', 's390', 's390x'] and \ 786 'ppc', 'ppc64', 's390', 's390x'] and \
787 ARCH_GUESS and arch != ARCH_GUESS 787 bool(ARCH_GUESS) and arch != ARCH_GUESS
788 # Find available test suites and read test cases from them. 788 # Find available test suites and read test cases from them.
789 variables = { 789 variables = {
790 "arch": arch, 790 "arch": arch,
791 "asan": options.asan, 791 "asan": options.asan,
792 "deopt_fuzzer": False, 792 "deopt_fuzzer": False,
793 "gc_stress": options.gc_stress, 793 "gc_stress": options.gc_stress,
794 "gcov_coverage": options.gcov_coverage, 794 "gcov_coverage": options.gcov_coverage,
795 "isolates": options.isolates, 795 "isolates": options.isolates,
796 "mode": MODES[mode]["status_mode"], 796 "mode": MODES[mode]["status_mode"],
797 "no_i18n": options.no_i18n, 797 "no_i18n": options.no_i18n,
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 "--coverage-dir=%s" % options.sancov_dir]) 925 "--coverage-dir=%s" % options.sancov_dir])
926 except: 926 except:
927 print >> sys.stderr, "Error: Merging sancov files failed." 927 print >> sys.stderr, "Error: Merging sancov files failed."
928 exit_code = 1 928 exit_code = 1
929 929
930 return exit_code 930 return exit_code
931 931
932 932
933 if __name__ == "__main__": 933 if __name__ == "__main__":
934 sys.exit(Main()) 934 sys.exit(Main())
OLDNEW
« no previous file with comments | « test/webkit/webkit.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698