Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2961813002: Rename handleFunctionType to endFunctionType. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
I'll be using the begin event in another CL.
3 years, 5 months ago (2017-06-27 15:30:37 UTC) #2
danrubel
LGTM
3 years, 5 months ago (2017-06-28 02:54:53 UTC) #3
ahe
3 years, 5 months ago (2017-06-28 08:01:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90fb88710fa0020d329d4b6b5e5fa24a4d4469f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698