Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2961673003: Reorganize parseType (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -51 lines) Patch
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +55 lines, -51 lines 3 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
ahe
This makes the next CL easier to read. https://codereview.chromium.org/2961673003/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2961673003/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode1166 pkg/front_end/lib/src/fasta/parser/parser.dart:1166: Token ...
3 years, 5 months ago (2017-06-27 15:39:23 UTC) #4
danrubel
LGTM https://codereview.chromium.org/2961673003/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2961673003/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode1213 pkg/front_end/lib/src/fasta/parser/parser.dart:1213: return commitType(); // This is a type, parse ...
3 years, 5 months ago (2017-06-28 03:04:41 UTC) #5
ahe
Thank you, Dan! https://codereview.chromium.org/2961673003/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2961673003/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode1213 pkg/front_end/lib/src/fasta/parser/parser.dart:1213: return commitType(); // This is a ...
3 years, 5 months ago (2017-06-28 08:02:57 UTC) #6
ahe
3 years, 5 months ago (2017-06-28 08:03:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
f10bdc6872f3db1b448caa026102fa31f600b51f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698