Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2958073002: Remove all type-related peeking. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -296 lines) Patch
M pkg/front_end/lib/src/fasta/parser/parser.dart View 11 chunks +286 lines, -281 lines 2 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.md View 1 chunk +0 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 2961673003 Patch 20001

Dependent Patchsets:

Issue 2963473004 Patch 1

Messages

Total messages: 6 (2 generated)
ahe
3 years, 5 months ago (2017-06-27 16:33:06 UTC) #2
danrubel
LGTM https://codereview.chromium.org/2958073002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2958073002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode215 pkg/front_end/lib/src/fasta/parser/parser.dart:215: SendOrFunctionLiteral, What is 'Send' ? An invocation or ...
3 years, 5 months ago (2017-06-28 03:22:00 UTC) #3
ahe
Thank you, Dan! https://codereview.chromium.org/2958073002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2958073002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode215 pkg/front_end/lib/src/fasta/parser/parser.dart:215: SendOrFunctionLiteral, On 2017/06/28 03:22:00, danrubel wrote: ...
3 years, 5 months ago (2017-06-28 08:06:58 UTC) #4
ahe
3 years, 5 months ago (2017-06-28 08:07:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
97454851b821dce61db25fba0143b26d4b149990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698