Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2961253002: [objects] Rename macros from DECLARE_ to DECL_ for consistency. (Closed)

Created:
3 years, 5 months ago by titzer
Modified:
3 years, 5 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[objects] Rename macros from DECLARE_ to DECL_ for consistency. R=marja@chromium.org BUG= Review-Url: https://codereview.chromium.org/2961253002 Cr-Commit-Position: refs/heads/master@{#46321} Committed: https://chromium.googlesource.com/v8/v8/+/d0565a9bda1f1eb94bdcf5fe54a2364f04c982a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -325 lines) Patch
M src/feedback-vector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects.h View 97 chunks +229 lines, -233 lines 0 comments Download
M src/objects/arguments.h View 5 chunks +9 lines, -9 lines 0 comments Download
M src/objects/code-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects/compilation-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects/debug-objects.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/objects/descriptor-array.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects/dictionary.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/objects/frame-array.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/objects/hash-table.h View 11 chunks +17 lines, -17 lines 0 comments Download
M src/objects/literal-objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects/map.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/objects/module-info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects/name.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/objects/object-macros.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects/object-macros-undef.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects/regexp-match-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects/scope-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects/script.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects/shared-function-info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects/string.h View 13 chunks +15 lines, -15 lines 0 comments Download
M src/objects/string-table.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
3 years, 5 months ago (2017-06-29 12:31:17 UTC) #1
marja
lgtm This has some conflict potential - maybe give people a heads up that this ...
3 years, 5 months ago (2017-06-29 12:59:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961253002/1
3 years, 5 months ago (2017-06-29 13:12:54 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 13:14:31 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d0565a9bda1f1eb94bdcf5fe54a2364f04c...

Powered by Google App Engine
This is Rietveld 408576698