Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2961243002: [CSS Typed OM] Implement FromCSSValue and AsMatrix for CSSTranslation (Closed)

Created:
3 years, 5 months ago by meade_UTC10
Modified:
3 years, 5 months ago
Reviewers:
nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Implement FromCSSValue and AsMatrix for CSSTranslation Spec: https://drafts.css-houdini.org/css-typed-om/#csstranslation Additionally found during testing: - Z should not be able to be set to null - Use new CSS.px(1) syntax for inlinestyle/translation test for brevity BUG=545318 Review-Url: https://codereview.chromium.org/2961243002 Cr-Commit-Position: refs/heads/master@{#486684} Committed: https://chromium.googlesource.com/chromium/src/+/6062c10e3936d8e0c3078e8485f754ccd37c120f

Patch Set 1 #

Patch Set 2 : Update return value of AsMatrix #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix test #

Patch Set 6 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -113 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 1 2 3 4 5 5 chunks +47 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html View 1 2 3 4 3 chunks +57 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp View 1 5 chunks +137 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (17 generated)
meade_UTC10
3 years, 5 months ago (2017-06-29 08:25:02 UTC) #3
nainar
lgtm
3 years, 5 months ago (2017-07-03 03:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961243002/40001
3 years, 5 months ago (2017-07-10 08:05:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/254190)
3 years, 5 months ago (2017-07-10 08:07:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961243002/60001
3 years, 5 months ago (2017-07-11 03:41:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/496430)
3 years, 5 months ago (2017-07-11 05:35:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961243002/80001
3 years, 5 months ago (2017-07-13 01:41:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/500023)
3 years, 5 months ago (2017-07-13 02:42:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961243002/100001
3 years, 5 months ago (2017-07-14 01:46:46 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/338340)
3 years, 5 months ago (2017-07-14 03:13:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961243002/100001
3 years, 5 months ago (2017-07-14 03:35:46 UTC) #26
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 05:11:39 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6062c10e3936d8e0c3078e8485f7...

Powered by Google App Engine
This is Rietveld 408576698