Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

Issue 2961243002: [CSS Typed OM] Implement FromCSSValue and AsMatrix for CSSTranslation (Closed)
Patch Set: fix test Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
index 069919b08be86b365a53ca621a4f8eb892aef4c0..1155435b7548d0ba2fe19846c28bfb593b5969d7 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
@@ -34,9 +34,11 @@ class CORE_EXPORT CSSTranslation final : public CSSTransformComponent {
ExceptionState&);
// Blink-internal ways of creating CSSTranslations.
- static CSSTranslation* FromCSSValue(const CSSFunctionValue& value) {
- return nullptr;
- }
+ static CSSTranslation* Create(CSSNumericValue* x, CSSNumericValue* y);
+ static CSSTranslation* Create(CSSNumericValue* x,
+ CSSNumericValue* y,
+ CSSNumericValue* z);
+ static CSSTranslation* FromCSSValue(const CSSFunctionValue&);
// Getters and setters for attributes defined in the IDL.
CSSNumericValue* x() const { return x_; }
@@ -48,8 +50,7 @@ class CORE_EXPORT CSSTranslation final : public CSSTransformComponent {
// Internal methods - from CSSTransformComponent.
TransformComponentType GetType() const final { return kTranslationType; }
- // TODO: Implement AsMatrix for CSSTranslation.
- DOMMatrix* AsMatrix() const final { return nullptr; }
+ DOMMatrix* AsMatrix() const final;
CSSFunctionValue* ToCSSValue() const final;
DEFINE_INLINE_VIRTUAL_TRACE() {

Powered by Google App Engine
This is Rietveld 408576698