Move base::WeakPtr's null ctor out-of-line

Move base::WeakPtr's null ctor out-of-line

They already invoke the out-of-line constructor for WeakPtrBase (which needs to
set up the WeakReference, so being out of line makes sense). Because of that,
doing ptr_ = nullptr inline doesn't any performance but costs size.

Since WeakPtr is a template, move the ptr_ member into the non-template
WeakPtrBase and initialize it in that class's out-of-line ctor.

This is expected to reduce the binary size by ~8KB on Android and 48KB on x64 Linux.

BUG=728324
Review-Url: https://codereview.chromium.org/2961083002
Cr-Commit-Position: refs/heads/master@{#483474}
Committed: https://chromium.googlesource.com/chromium/src/+/cc65b2990c22909896c5b08ad5e6b159a6bef5f5

[hans, 2017-06-28 17:46:05]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 17:46:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 18:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:44:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hans, 2017-06-28 20:12:33]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 20:13:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-06-28 20:54:02]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-06-28 20:54:03]

lgtm

[hans, 2017-06-28 21:07:12]

Description was changed from

==========
Move base::WeakPtr's null ctor out-of-line

They already invoke the out-of-line constructor for WeakPtrBase (which needs to
set up the WeakReference, so being out of line makes sense). Because of that,
doing ptr_ = nullptr inline doesn't any performance but costs size.

Since WeakPtr is a template, move the ptr_ member into the non-template
WeakPtrBase and initialize it in that class's out-of-line ctor.

BUG=728324
==========

to

==========
Move base::WeakPtr's null ctor out-of-line

They already invoke the out-of-line constructor for WeakPtrBase (which needs to
set up the WeakReference, so being out of line makes sense). Because of that,
doing ptr_ = nullptr inline doesn't any performance but costs size.

Since WeakPtr is a template, move the ptr_ member into the non-template
WeakPtrBase and initialize it in that class's out-of-line ctor.

This is expected to reduce the binary size by ~8KB on Android and 48KB on x64
Linux.

BUG=728324
==========

[commit-bot: I haz the power, 2017-06-28 22:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 22:20:41]

Dry run: This issue passed the CQ dry run.

[hans, 2017-06-29 18:30:42]

The CQ bit was checked by hans@chromium.org

[hans, 2017-06-29 18:30:43]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2961083002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-29 18:31:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 20:35:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498761042822670,
"parent_rev": "e6f876b52fbb23a2babd3d8cb45d2dadcfa3d2c3", "commit_rev":
"3893c2ceac6b643026b4407506904f9b78a0d5ca"}

[commit-bot: I haz the power, 2017-06-29 20:35:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498761042822670,
"parent_rev": "e34d74248235b57ce7c4a9ba05956f5f3f12d8c3", "commit_rev":
"cc65b2990c22909896c5b08ad5e6b159a6bef5f5"}

[commit-bot: I haz the power, 2017-06-29 20:35:58]

Description was changed from

==========
Move base::WeakPtr's null ctor out-of-line

They already invoke the out-of-line constructor for WeakPtrBase (which needs to
set up the WeakReference, so being out of line makes sense). Because of that,
doing ptr_ = nullptr inline doesn't any performance but costs size.

Since WeakPtr is a template, move the ptr_ member into the non-template
WeakPtrBase and initialize it in that class's out-of-line ctor.

This is expected to reduce the binary size by ~8KB on Android and 48KB on x64
Linux.

BUG=728324
==========

to

==========
Move base::WeakPtr's null ctor out-of-line

They already invoke the out-of-line constructor for WeakPtrBase (which needs to
set up the WeakReference, so being out of line makes sense). Because of that,
doing ptr_ = nullptr inline doesn't any performance but costs size.

Since WeakPtr is a template, move the ptr_ member into the non-template
WeakPtrBase and initialize it in that class's out-of-line ctor.

This is expected to reduce the binary size by ~8KB on Android and 48KB on x64
Linux.

BUG=728324

Review-Url: https://codereview.chromium.org/2961083002
Cr-Commit-Position: refs/heads/master@{#483474}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc65b2990c22909896c5b08ad5e6...
==========

[commit-bot: I haz the power, 2017-06-29 20:36:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cc65b2990c22909896c5b08ad5e6...