Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: base/memory/weak_ptr.cc

Issue 2961083002: Move base::WeakPtr's null ctor out-of-line (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/weak_ptr.h ('k') | base/memory/weak_ptr_unittest.nc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/weak_ptr.h" 5 #include "base/memory/weak_ptr.h"
6 6
7 #include "base/debug/leak_annotations.h" 7 #include "base/debug/leak_annotations.h"
8 8
9 namespace base { 9 namespace base {
10 namespace internal { 10 namespace internal {
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 flag_ = new WeakReference::Flag(); 64 flag_ = new WeakReference::Flag();
65 65
66 return WeakReference(flag_.get()); 66 return WeakReference(flag_.get());
67 } 67 }
68 68
69 void WeakReferenceOwner::Invalidate() { 69 void WeakReferenceOwner::Invalidate() {
70 flag_->Invalidate(); 70 flag_->Invalidate();
71 flag_ = WeakReference::Flag::NullFlag(); 71 flag_ = WeakReference::Flag::NullFlag();
72 } 72 }
73 73
74 WeakPtrBase::WeakPtrBase() { 74 WeakPtrBase::WeakPtrBase() : ptr_(0) {}
75 }
76 75
77 WeakPtrBase::~WeakPtrBase() { 76 WeakPtrBase::~WeakPtrBase() {}
78 }
79 77
80 WeakPtrBase::WeakPtrBase(const WeakReference& ref) : ref_(ref) { 78 WeakPtrBase::WeakPtrBase(const WeakReference& ref, uintptr_t ptr)
81 } 79 : ref_(ref), ptr_(ptr) {}
82 80
83 WeakPtrFactoryBase::WeakPtrFactoryBase(uintptr_t ptr) : ptr_(ptr) {} 81 WeakPtrFactoryBase::WeakPtrFactoryBase(uintptr_t ptr) : ptr_(ptr) {}
84 82
85 WeakPtrFactoryBase::~WeakPtrFactoryBase() { 83 WeakPtrFactoryBase::~WeakPtrFactoryBase() {
86 ptr_ = 0; 84 ptr_ = 0;
87 } 85 }
88 86
89 } // namespace internal 87 } // namespace internal
90 } // namespace base 88 } // namespace base
OLDNEW
« no previous file with comments | « base/memory/weak_ptr.h ('k') | base/memory/weak_ptr_unittest.nc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698