Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2960973002:
Work around dllimport member function pointer bug in clang (Closed)
|
Created:
3 years, 5 months ago by Reid Kleckner Modified:
3 years, 5 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionWork around dllimport member function pointer bug in clang
R=guidou@chromium.org,thakis@chromium.org
BUG=736309
Review-Url: https://codereview.chromium.org/2960973002
Cr-Commit-Position: refs/heads/master@{#482973}
Committed: https://chromium.googlesource.com/chromium/src/+/b53707058233012ea4ac5efae690506e111bde37
Patch Set 1 #Patch Set 2 : remove whitespace change #
Total comments: 1
Messages
Total messages: 18 (9 generated)
lgtm
The CQ bit was checked by guidou@chromium.org
The CQ bit was unchecked by guidou@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2960973002/diff/20001/content/renderer/media/... File content/renderer/media/media_stream_constraints_util_audio_unittest.cc (right): https://codereview.chromium.org/2960973002/diff/20001/content/renderer/media/... content/renderer/media/media_stream_constraints_util_audio_unittest.cc:348: // failing on some build configurations. Did you mean to revert this to the lhs of https://codereview.chromium.org/2958543002 too? Else, isn't this bug already worked around?
On 2017/06/28 13:16:11, Nico (vacation Jun 30-Jul 11) wrote: > https://codereview.chromium.org/2960973002/diff/20001/content/renderer/media/... > File content/renderer/media/media_stream_constraints_util_audio_unittest.cc > (right): > > https://codereview.chromium.org/2960973002/diff/20001/content/renderer/media/... > content/renderer/media/media_stream_constraints_util_audio_unittest.cc:348: // > failing on some build configurations. > Did you mean to revert this to the lhs of > https://codereview.chromium.org/2958543002 too? Else, isn't this bug already > worked around? https://codereview.chromium.org/2958543002 did not fix the bot. I'm not sure if the comparisons that were patched there were failing on clang dll, but Reid probably knows. I think we can land this, and if the bot gets green, revert https://codereview.chromium.org/2958543002 and see what happens. If it goes back to red, reland https://codereview.chromium.org/2958543002.
On 2017/06/28 13:16:11, Nico (vacation Jun 30-Jul 11) wrote: > https://codereview.chromium.org/2960973002/diff/20001/content/renderer/media/... > File content/renderer/media/media_stream_constraints_util_audio_unittest.cc > (right): > > https://codereview.chromium.org/2960973002/diff/20001/content/renderer/media/... > content/renderer/media/media_stream_constraints_util_audio_unittest.cc:348: // > failing on some build configurations. > Did you mean to revert this to the lhs of > https://codereview.chromium.org/2958543002 too? Else, isn't this bug already > worked around? https://codereview.chromium.org/2958543002 did not fix the bot. I'm not sure if the comparisons that were patched there were failing on clang dll, but Reid probably knows. I think we can land this, and if the bot gets green, revert https://codereview.chromium.org/2958543002 and see what happens. If it goes back to red, reland https://codereview.chromium.org/2958543002.
ah, thanks, lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498658156919460,
"parent_rev": "ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185", "commit_rev":
"b53707058233012ea4ac5efae690506e111bde37"}
Message was sent while issue was closed.
Description was changed from ========== Work around dllimport member function pointer bug in clang R=guidou@chromium.org,thakis@chromium.org BUG=736309 ========== to ========== Work around dllimport member function pointer bug in clang R=guidou@chromium.org,thakis@chromium.org BUG=736309 Review-Url: https://codereview.chromium.org/2960973002 Cr-Commit-Position: refs/heads/master@{#482973} Committed: https://chromium.googlesource.com/chromium/src/+/b53707058233012ea4ac5efae690... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b53707058233012ea4ac5efae690... |
