Work around dllimport member function pointer bug in clang

content/renderer/media/media_stream_constraints_util_audio_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_constraints_util_audio.h"
 
 #include <cmath>
 #include <string>
 #include <utility>
 
@@ skipping 308 matching lines @@
   // All settings should have default values.
   EXPECT_TRUE(result.HasValue());
   CheckAllDefaults(AudioSettingsBoolMembers(), AudioPropertiesBoolMembers(),
                    result);
 }
 
 // This test checks all possible ways to set boolean constraints (except
 // echo cancellation constraints, which are not mapped 1:1 to output audio
 // processing properties).
 TEST_P(MediaStreamConstraintsUtilAudioTest, SingleBoolConstraint) {
-  const AudioSettingsBoolMembers kMainSettings = {
-      &AudioCaptureSettings::hotword_enabled,
-      &AudioCaptureSettings::disable_local_echo,
-      &AudioCaptureSettings::render_to_associated_sink};
+  // TODO(crbug.com/736309): Use braced initialization instead of push_back once
+  // clang has been fixed.
+  AudioSettingsBoolMembers kMainSettings;
+  kMainSettings.push_back(&AudioCaptureSettings::hotword_enabled);
+  kMainSettings.push_back(&AudioCaptureSettings::disable_local_echo);
+  kMainSettings.push_back(&AudioCaptureSettings::render_to_associated_sink);
 
   const std::vector<
       blink::BooleanConstraint blink::WebMediaTrackConstraintSet::*>
       kMainBoolConstraints = {
           &blink::WebMediaTrackConstraintSet::hotword_enabled,
           &blink::WebMediaTrackConstraintSet::disable_local_echo,
           &blink::WebMediaTrackConstraintSet::render_to_associated_sink};
 
   ASSERT_EQ(kMainSettings.size(), kMainBoolConstraints.size());
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
       // Using array elements instead of pointer values due to the comparison
       // failing on some build configurations.

[Nico, 2017/06/28 13:16:11]

Did you mean to revert this to the lhs of
https://codereview.chromium.org/2958543002 too? Else, isn't this bug already
worked around?

       if (set_function == kBoolSetFunctions[1] &&
           accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (size_t i = 0; i < kMainSettings.size(); ++i) {
         for (bool value : kBoolValues) {
           ResetFactory();
           (((constraint_factory_.*accessor)().*kMainBoolConstraints[i]).*
            set_function)(value);
           auto result = SelectSettings();
@@ skipping 609 matching lines @@
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         MediaStreamConstraintsUtilAudioTest,
                         testing::Values("",
                                         kMediaStreamSourceTab,
                                         kMediaStreamSourceSystem,
                                         kMediaStreamSourceDesktop));
 
 }  // namespace content