Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2960773002: M60 merge: MD Settings: Allow editing startup URLs when "recommended" policy is present. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

M60 merge: MD Settings: Allow editing startup URLs when "recommended" policy is present. Before this CL, "recommended" and "managed" startup URL policies were treated identically. BUG=732471 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2953343002 Cr-Original-Commit-Position: refs/heads/master@{#482082} Review-Url: https://codereview.chromium.org/2960773002 . Cr-Commit-Position: refs/branch-heads/3112@{#469} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/0200c8a2a2542eb3f87c32d7f9da5f46b8e71360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dpapad
Need an LG to merge this to M60. It was approved at https://bugs.chromium.org/p/chromium/issues/detail?id=732471#c29.
3 years, 5 months ago (2017-06-26 22:27:34 UTC) #2
Lei Zhang
On 2017/06/26 22:27:34, dpapad wrote: > Need an LG to merge this to M60. It ...
3 years, 5 months ago (2017-06-26 22:36:21 UTC) #3
dpapad
Committed patchset #1 (id:1) manually as 0200c8a2a2542eb3f87c32d7f9da5f46b8e71360.
3 years, 5 months ago (2017-06-26 22:41:49 UTC) #5
dpapad
3 years, 5 months ago (2017-06-26 22:47:40 UTC) #6
Message was sent while issue was closed.
On 2017/06/26 at 22:36:21, thestig wrote:
> On 2017/06/26 22:27:34, dpapad wrote:
> > Need an LG to merge this to M60. It was approved at
> > https://bugs.chromium.org/p/chromium/issues/detail?id=732471#c29.
> 
> I don't think you need one. Land with --bypass-hooks if you are doing this
manually?

Done.

Powered by Google App Engine
This is Rietveld 408576698