MD Settings: Allow editing startup URLs when "recommended" policy is present.

MD Settings: Allow editing startup URLs when "recommended" policy is present.

Before this CL, "recommended" and "managed" startup URL policies were treated
identically.

BUG=732471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2953343002
Cr-Commit-Position: refs/heads/master@{#482082}
Committed: https://chromium.googlesource.com/chromium/src/+/c9a02feda8372a18c1b2d124448424225148698b

[dpapad, 2017-06-23 22:39:50]

Description was changed from

==========
MD Settings: Allow editing startup URLs when "recommended" policy is present.

Before this CL, "recommended" and "managed" startup URL policies were treated
identically.

BUG=732471
==========

to

==========
MD Settings: Allow editing startup URLs when "recommended" policy is present.

Before this CL, "recommended" and "managed" startup URL policies were treated
identically.

BUG=732471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-23 22:43:35]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 22:43:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-23 22:51:04]

dpapad@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dpapad, 2017-06-23 22:51:05]

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
(right):

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.html:41:
prefs.session.startup_urls.enforcement)]]">
Is |enforcement| always set, even when this pref is controlled by an extension?
The test at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/startup_...
suggests so, but want to double check to ensure we are not regressing the
controlled by extension case. 

If this LG, I'll start working on a test (and possibly send as a separate CL).

[dpapad, 2017-06-23 22:51:26]

Also see screenshots of managed/recommended at http://imgur.com/a/PkLdY.

[stevenjb, 2017-06-23 23:13:15]

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
(right):

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.html:41:
prefs.session.startup_urls.enforcement)]]">
On 2017/06/23 22:51:04, dpapad wrote:
> Is |enforcement| always set, even when this pref is controlled by an
extension?
> The test at
>
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/startup_...
> suggests so, but want to double check to ensure we are not regressing the
> controlled by extension case. 
> 
> If this LG, I'll start working on a test (and possibly send as a separate CL).

This is the only place that I am aware of that we set CONTROLLED_BY_EXTENSION,
and enforcement is always set to ENFORCED:

https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/settings_p...

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.html:47:
prefs.session.startup_urls.enforcement)]]" restamp>
I forget, is this guaranteed to get stamped if enforcement is not defined?

[dpapad, 2017-06-23 23:42:30]

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
(right):

https://codereview.chromium.org/2953343002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.html:47:
prefs.session.startup_urls.enforcement)]]" restamp>
On 2017/06/23 at 23:13:15, stevenjb wrote:
> I forget, is this guaranteed to get stamped if enforcement is not defined?

Yes. I had the same question, so I made a minimal example at
https://jsfiddle.net/sf3rtyny/. Basically as long as |prefs| is defined, the
function will be called, even if subproperties are undefined.

FWIW, this is not documented so explicitly in Polymer's doc, I only reached this
conclusion by experimentation.

Polymer's docs at
https://www.polymer-project.org/1.0/docs/devguide/data-binding#annotated-comp...
say
"As with observers and computed properties, the computing function is not called
until all dependent properties are defined (!=undefined)."

[stevenjb, 2017-06-23 23:47:40]

Yeah, OK, thanks for the confirmation and the reference. LGTM

[dpapad, 2017-06-23 23:52:59]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-06-23 23:53:00]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-23 23:53:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 00:06:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498261980977610,
"parent_rev": "47da9855562f7261d9b10ad91fb6fe3c6688abd6", "commit_rev":
"c9a02feda8372a18c1b2d124448424225148698b"}

[commit-bot: I haz the power, 2017-06-24 00:06:34]

Description was changed from

==========
MD Settings: Allow editing startup URLs when "recommended" policy is present.

Before this CL, "recommended" and "managed" startup URL policies were treated
identically.

BUG=732471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Allow editing startup URLs when "recommended" policy is present.

Before this CL, "recommended" and "managed" startup URL policies were treated
identically.

BUG=732471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2953343002
Cr-Commit-Position: refs/heads/master@{#482082}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9a02feda8372a18c1b2d1244484...
==========

[commit-bot: I haz the power, 2017-06-24 00:06:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9a02feda8372a18c1b2d1244484...