content/public/common/browser_side_navigation_policy.cc - Issue 2960703003: Add a feature flag for network service and about:flags entry for it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/browser_side_navigation_policy.cc

Issue 2960703003: Add a feature flag for network service and about:flags entry for it. (Closed)

Patch Set: more updates Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/service_worker/service_worker_request_handler.cc ('K') | « content/common/service_worker/service_worker_utils.cc ('k') | content/public/common/content_features.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/public/common/browser_side_navigation_policy.h"	5 #include "content/public/common/browser_side_navigation_policy.h"

6	6

7 #include "base/command_line.h"	7 #include "base/command_line.h"

8 #include "content/public/common/content_features.h"	8 #include "content/public/common/content_features.h"

9 #include "content/public/common/content_switches.h"	9 #include "content/public/common/content_switches.h"

10	10

11 namespace content {	11 namespace content {

12	12

13 bool IsBrowserSideNavigationEnabled() {	13 bool IsBrowserSideNavigationEnabled() {

14 return	14 return base::CommandLine::ForCurrentProcess()->HasSwitch(

15 base::CommandLine::ForCurrentProcess()->HasSwitch(	15 switches::kEnableBrowserSideNavigation) \|\|

16 switches::kEnableBrowserSideNavigation) \|\|	16 base::FeatureList::IsEnabled(features::kBrowserSideNavigation) \|\|

17 base::FeatureList::IsEnabled(features::kBrowserSideNavigation);	17 base::FeatureList::IsEnabled(features::kNetworkService);
	Alexei Svitkine (slow) 2017/06/29 13:58:24 Shouldn't this be () && net enabled? Otherwise, i Shouldn't this be () && net enabled? Otherwise, it will enable browser side navigation even if kBrowserSideNavigation is not enabled. (Separately, could we also remove switches::kEnableBrowserSideNavigation since there's a feature?) jam 2017/06/30 17:21:18 Yep that's the intended behavior. Network Service Show quoted text On 2017/06/29 13:58:24, Alexei Svitkine (slow) wrote: > Shouldn't this be () && net enabled? > > Otherwise, it will enable browser side navigation even if kBrowserSideNavigation > is not enabled. Yep that's the intended behavior. Network Service depends on MojoLoading and BrowserSideNavigation. Show quoted text > > (Separately, could we also remove switches::kEnableBrowserSideNavigation since > there's a feature?) This is historical before the feature and is used by bots and locally be devs. PlzNavigate will get turned on soon, so we'll take both out then.
18 }	18 }

19	19

20 } // namespace content	20 } // namespace content

OLD	NEW