Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2960663002: Remove unnecessary check if RenderFrame::GetWebFrame() returns null. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary check if RenderFrame::GetWebFrame() returns null. RenderFrame::BindToFrame is called almost immediately after construction of a RenderFrame - the check whether RenderFrame::GetWebFrame() returns null should not be necessary. BUG=416660 Review-Url: https://codereview.chromium.org/2960663002 Cr-Commit-Position: refs/heads/master@{#482411} Committed: https://chromium.googlesource.com/chromium/src/+/91009bce0f7eab2b03e41ee66128e4b6c7b0917a

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M android_webview/renderer/aw_render_view_ext.cc View 1 chunk +1 line, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
Łukasz Anforowicz
boliu@, could you PTAL? This is a follow-up to https://codereview.chromium.org/2953193002/diff/20001/android_webview/renderer/aw_render_view_ext.cc#newcode62 and in theory should be ...
3 years, 5 months ago (2017-06-26 19:19:17 UTC) #10
boliu
lgtm
3 years, 5 months ago (2017-06-26 19:51:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960663002/20001
3 years, 5 months ago (2017-06-26 21:27:00 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 21:31:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/91009bce0f7eab2b03e41ee66128...

Powered by Google App Engine
This is Rietveld 408576698