Remove total item count in remove profile warning

Remove total item count in remove profile warning

This CL removes the total_items count from the remove profile
dialog. This number is not very meaningful and for non-sync users,
we already show individual counts. (17421 total items in my profile)

Syncing users don't lose their data because they can login again, 
so I also remove the total count there and replace the text with a
less scary one.

Context: http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#heading=h.1iob68izxmk8

BUG=716267
Review-Url: https://codereview.chromium.org/2960613002
Cr-Commit-Position: refs/heads/master@{#484554}
Committed: https://chromium.googlesource.com/chromium/src/+/585385f55243a72141eefbe744a7d2b1c430cf8f

[dullweber, 2017-06-30 12:17:27]

Description was changed from

==========
Remove error state for profile statistics

Due to the changes to the profile statistics counters, it is not
possible anymore to have failed counts. This CL removes the error case
that was used when a value couldn't be determined.

BUG=716267
==========

to

==========
Remove total item count in profile statistics

This CL removes the total_items count from the remove profile
dialog. This number is not very meaningful and for non-sync users,
we already show individual counts. Syncing users don't lose their 
data because they can login again, this is already meantioned in the
text, so removing the item count makes it less scary.
(17421 items in my profile...)

Context:
http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#head...

BUG=716267
==========

[dullweber, 2017-06-30 12:17:33]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 12:17:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 13:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 13:19:33]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-07-03 13:48:22]

Description was changed from

==========
Remove total item count in profile statistics

This CL removes the total_items count from the remove profile
dialog. This number is not very meaningful and for non-sync users,
we already show individual counts. Syncing users don't lose their 
data because they can login again, this is already meantioned in the
text, so removing the item count makes it less scary.
(17421 items in my profile...)

Context:
http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#head...

BUG=716267
==========

to

==========
Remove total item count in remove profile warning

This CL removes the total_items count from the remove profile
dialog. This number is not very meaningful and for non-sync users,
we already show individual counts. (17421 total items in my profile)

Syncing users don't lose their data because they can login again, 
so I also remove the total count there and replace the text with a
less scary one.

Context:
http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#head...

BUG=716267
==========

[dullweber, 2017-07-03 15:01:29]

dullweber@chromium.org changed reviewers:
+ jdufault@chromium.org, msarda@chromium.org

[dullweber, 2017-07-03 15:01:29]

msarda@chromium.org: Please review changes in 
  chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
jdufault@chromium.org: Please review changes in 
  ui/login/account_picker/

Jacob, the diff for user_pod_row and md_user_pod_row should be exactly the same
but I would like to test chrome with md_user_pod_row, how do I turn it on?

[msarda, 2017-07-04 16:05:23]

LGTM for chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

[jdufault, 2017-07-05 16:56:50]

lgtm

> Jacob, the diff for user_pod_row and md_user_pod_row should be exactly the
same
> but I would like to test chrome with md_user_pod_row, how do I turn it on?

md_user_pod_row is not used for desktop chrome user switcher, so it is not
possible to test :)

Eventually, md_user_pod_row will be removed entirely - it's TBD on what we do
for the desktop chrome profile switcher code.

[dullweber, 2017-07-06 11:17:33]

On 2017/07/05 16:56:50, jdufault wrote:
> lgtm
> 
> > Jacob, the diff for user_pod_row and md_user_pod_row should be exactly the
> same
> > but I would like to test chrome with md_user_pod_row, how do I turn it on?
> 
> md_user_pod_row is not used for desktop chrome user switcher, so it is not
> possible to test :)
> 
> Eventually, md_user_pod_row will be removed entirely - it's TBD on what we do
> for the desktop chrome profile switcher code.

thanks, but always doing changes in both files is the right approach?

[dullweber, 2017-07-06 11:27:49]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-07-06 11:27:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 12:40:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499340469057300,
"parent_rev": "eb22964328a0eb01e917d19109beed89584b9540", "commit_rev":
"585385f55243a72141eefbe744a7d2b1c430cf8f"}

[commit-bot: I haz the power, 2017-07-06 12:40:46]

Description was changed from

==========
Remove total item count in remove profile warning

This CL removes the total_items count from the remove profile
dialog. This number is not very meaningful and for non-sync users,
we already show individual counts. (17421 total items in my profile)

Syncing users don't lose their data because they can login again, 
so I also remove the total count there and replace the text with a
less scary one.

Context:
http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#head...

BUG=716267
==========

to

==========
Remove total item count in remove profile warning

This CL removes the total_items count from the remove profile
dialog. This number is not very meaningful and for non-sync users,
we already show individual counts. (17421 total items in my profile)

Syncing users don't lose their data because they can login again, 
so I also remove the total count there and replace the text with a
less scary one.

Context:
http://docs/document/d/1ts465ST49BXSft8lsaQ2CxzJy_-4aa-vq23KOUTVvyI/edit#head...

BUG=716267

Review-Url: https://codereview.chromium.org/2960613002
Cr-Commit-Position: refs/heads/master@{#484554}
Committed:
https://chromium.googlesource.com/chromium/src/+/585385f55243a72141eefbe744a7...
==========

[commit-bot: I haz the power, 2017-07-06 12:40:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/585385f55243a72141eefbe744a7...

[jdufault, 2017-07-06 18:10:52]

On 2017/07/06 11:17:33, dullweber wrote:
> On 2017/07/05 16:56:50, jdufault wrote:
> > lgtm
> > 
> > > Jacob, the diff for user_pod_row and md_user_pod_row should be exactly the
> > same
> > > but I would like to test chrome with md_user_pod_row, how do I turn it on?
> > 
> > md_user_pod_row is not used for desktop chrome user switcher, so it is not
> > possible to test :)
> > 
> > Eventually, md_user_pod_row will be removed entirely - it's TBD on what we
do
> > for the desktop chrome profile switcher code.
> 
> thanks, but always doing changes in both files is the right approach?

yes - we should keep them in sync.