Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2960543002: Revert of Add support for $i18n{} localized strings to ios/web. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
Reviewers:
michaeldo, Dan Beam
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for $i18n{} localized strings to ios/web. (patchset #2 id:20001 of https://codereview.chromium.org/2952743002/ ) Reason for revert: This change makes WebUITestCase.testChromeURLBackAndForwardNavigation crash. Original issue's description: > Add support for $i18n{} localized strings to ios/web. > > The html templates used for chrome:// pages have been updated with new > i18n support using $i18n{} style strings over the older i18n-content. > > BUG=734079 > > Review-Url: https://codereview.chromium.org/2952743002 > Cr-Commit-Position: refs/heads/master@{#481966} > Committed: https://chromium.googlesource.com/chromium/src/+/dcbf479ada2b075d70ab33dfa39b5a1891539b2a TBR=dbeam@chromium.org,michaeldo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=734079 Review-Url: https://codereview.chromium.org/2960543002 Cr-Commit-Position: refs/heads/master@{#482133} Committed: https://chromium.googlesource.com/chromium/src/+/7e18c32950f83dc1d94420eee6299869ad4c44b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -59 lines) Patch
M ios/web/public/web_ui_ios_data_source.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.h View 5 chunks +2 lines, -16 lines 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.mm View 5 chunks +4 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Eugene But (OOO till 7-30)
Created Revert of Add support for $i18n{} localized strings to ios/web.
3 years, 6 months ago (2017-06-24 03:25:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960543002/1
3 years, 6 months ago (2017-06-24 03:25:27 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-24 03:25:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e18c32950f83dc1d94420eee629...

Powered by Google App Engine
This is Rietveld 408576698