Add support for $i18n{} localized strings to ios/web.

Add support for $i18n{} localized strings to ios/web.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079
Review-Url: https://codereview.chromium.org/2952743002
Cr-Commit-Position: refs/heads/master@{#481966}
Committed: https://chromium.googlesource.com/chromium/src/+/dcbf479ada2b075d70ab33dfa39b5a1891539b2a

[michaeldo, 2017-06-20 22:35:01]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[michaeldo, 2017-06-20 22:35:17]

Description was changed from

==========
Add support for $i18n{} localized strings.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079
==========

to

==========
Add support for $i18n{} localized strings.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079
==========

[michaeldo, 2017-06-20 22:35:25]

Description was changed from

==========
Add support for $i18n{} localized strings.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079
==========

to

==========
Add support for $i18n{} localized strings to ios/web.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079
==========

[Eugene But (OOO till 7-30), 2017-06-21 00:21:46]

lgtm

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
File ios/web/webui/web_ui_ios_data_source_impl.h (right):

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
ios/web/webui/web_ui_ios_data_source_impl.h:46: void
SendFromResourceBundle(const std::string& path,
What is |path|? Is it related to |idr|? Please explain in the comments.

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
ios/web/webui/web_ui_ios_data_source_impl.h:58: // Add the locale to the load
time data defaults. May be called repeatedly.
s/Add/Adds

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
File ios/web/webui/web_ui_ios_data_source_impl.mm (right):

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
ios/web/webui/web_ui_ios_data_source_impl.mm:69:
add_load_time_data_defaults_(true),
Do you want to reverse this boolean to load_time_data_defaults_added? Otherwise
name sounds like an action.

[michaeldo, 2017-06-21 16:56:26]

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
File ios/web/webui/web_ui_ios_data_source_impl.h (right):

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
ios/web/webui/web_ui_ios_data_source_impl.h:46: void
SendFromResourceBundle(const std::string& path,
On 2017/06/21 00:21:46, Eugene But wrote:
> What is |path|? Is it related to |idr|? Please explain in the comments.

Done.

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
ios/web/webui/web_ui_ios_data_source_impl.h:58: // Add the locale to the load
time data defaults. May be called repeatedly.
On 2017/06/21 00:21:46, Eugene But wrote:
> s/Add/Adds

Done.

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
File ios/web/webui/web_ui_ios_data_source_impl.mm (right):

https://codereview.chromium.org/2952743002/diff/1/ios/web/webui/web_ui_ios_da...
ios/web/webui/web_ui_ios_data_source_impl.mm:69:
add_load_time_data_defaults_(true),
On 2017/06/21 00:21:46, Eugene But wrote:
> Do you want to reverse this boolean to load_time_data_defaults_added?
Otherwise
> name sounds like an action.

Yes, totally agree. Thanks for catching this.

[michaeldo, 2017-06-23 18:23:26]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-06-23 18:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2952743002/#ps20001
(title: "Respond to comments.")

[commit-bot: I haz the power, 2017-06-23 18:23:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 18:37:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498242206698810,
"parent_rev": "d01a037d86740ac4305350dbbb1dd95d816d3d0e", "commit_rev":
"dcbf479ada2b075d70ab33dfa39b5a1891539b2a"}

[commit-bot: I haz the power, 2017-06-23 18:37:42]

Description was changed from

==========
Add support for $i18n{} localized strings to ios/web.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079
==========

to

==========
Add support for $i18n{} localized strings to ios/web.

The html templates used for chrome:// pages have been updated with new
i18n support using $i18n{} style strings over the older i18n-content.

BUG=734079

Review-Url: https://codereview.chromium.org/2952743002
Cr-Commit-Position: refs/heads/master@{#481966}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcbf479ada2b075d70ab33dfa39b...
==========

[commit-bot: I haz the power, 2017-06-23 18:37:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dcbf479ada2b075d70ab33dfa39b...

[Dan Beam, 2017-06-23 21:41:14]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-06-23 21:41:15]

putting the template replacement code in ui/base paid off after all :)

[Eugene But (OOO till 7-30), 2017-06-24 03:25:14]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2960543002/ by eugenebut@chromium.org.

The reason for reverting is: This change makes
WebUITestCase.testChromeURLBackAndForwardNavigation crash..

[dschuyler, 2017-06-26 20:41:36]

dschuyler@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dschuyler, 2017-06-26 20:41:37]

https://codereview.chromium.org/2952743002/diff/20001/ios/web/webui/web_ui_io...
File ios/web/webui/web_ui_ios_data_source_impl.mm (right):

https://codereview.chromium.org/2952743002/diff/20001/ios/web/webui/web_ui_io...
ios/web/webui/web_ui_ios_data_source_impl.mm:148: load_time_data_defaults_added_
= false;
Consider reversing true/false used on load_time_data_defaults_added_ so that
it's false when the load_time_data_defaults_ have not been added and true once
the load_time_data_defaults_ have been added.

[michaeldo, 2017-06-27 21:24:18]

On 2017/06/26 20:41:37, dschuyler wrote:
>
https://codereview.chromium.org/2952743002/diff/20001/ios/web/webui/web_ui_io...
> File ios/web/webui/web_ui_ios_data_source_impl.mm (right):
> 
>
https://codereview.chromium.org/2952743002/diff/20001/ios/web/webui/web_ui_io...
> ios/web/webui/web_ui_ios_data_source_impl.mm:148:
load_time_data_defaults_added_
> = false;
> Consider reversing true/false used on load_time_data_defaults_added_ so that
> it's false when the load_time_data_defaults_ have not been added and true once
> the load_time_data_defaults_ have been added.

Thank you for catching that, I updated the name but forgot to switch the
actually logic. I made this change here:
https://codereview.chromium.org/2961893002