VR: Add support for time-aware unit tests.

VR: Add support for time-aware unit tests.

Add an initial unit test for the transient WebVR warning. This CL is a
lead-in to pulling common transient code out of scene manager and
specific elements.

Note that this development seemed to expose a bug in the mock task
runner, in conjunction with timers. This bug is now blocked on that
bug.

BUG=735163
Review-Url: https://codereview.chromium.org/2960533002
Cr-Commit-Position: refs/heads/master@{#482294}
Committed: https://chromium.googlesource.com/chromium/src/+/2f5d2f7b0721ace2fcbe408d8374f1c8277c71de

[cjgrant, 2017-06-24 02:14:30]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, ymalik@chromium.org

[cjgrant, 2017-06-24 02:14:31]

Folks, this lays groundwork for unit-testing of transient visibility (eg.
toasts, transient URL bar, loading indicator, etc).

[cjgrant, 2017-06-24 02:14:43]

The CQ bit was checked by cjgrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-24 02:14:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 02:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 02:25:05]

Dry run: This issue passed the CQ dry run.

[ymalik, 2017-06-26 14:55:21]

lgtm

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc (right):

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc:157: //
TODO(crbug.com/736558): Fast forwarding appears broken in conjunction with
Nit: Spoke offline, since there's nothing actionable here, probably make this a
note?

[bshe, 2017-06-26 15:40:17]

lgtm

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc (right):

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc:107:
base::ScopedMockTimeMessageLoopTaskRunner task_runner_;
optional nit: should we define this in the test that are time aware? Not sure
how many other tests need this.

[cjgrant, 2017-06-26 16:26:35]

Thanks guys, nits addressed.

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc (right):

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc:107:
base::ScopedMockTimeMessageLoopTaskRunner task_runner_;
On 2017/06/26 15:40:17, bshe wrote:
> optional nit: should we define this in the test that are time aware? Not sure
> how many other tests need this.

Done.

https://codereview.chromium.org/2960533002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc:157: //
TODO(crbug.com/736558): Fast forwarding appears broken in conjunction with
On 2017/06/26 14:55:21, ymalik wrote:
> Nit: Spoke offline, since there's nothing actionable here, probably make this
a
> note?

Done.  And improved the explanation.

[cjgrant, 2017-06-26 16:26:40]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-06-26 16:26:40]

The patchset sent to the CQ was uploaded after l-g-t-m from ymalik@chromium.org,
bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2960533002/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2017-06-26 16:26:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 16:39:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498494400446650,
"parent_rev": "6d4d2da0bda314416b87c1c3dde87ac96e9634f4", "commit_rev":
"2f5d2f7b0721ace2fcbe408d8374f1c8277c71de"}

[commit-bot: I haz the power, 2017-06-26 16:39:42]

Description was changed from

==========
VR: Add support for time-aware unit tests.

Add an initial unit test for the transient WebVR warning. This CL is a
lead-in to pulling common transient code out of scene manager and
specific elements.

Note that this development seemed to expose a bug in the mock task
runner, in conjunction with timers. This bug is now blocked on that
bug.

BUG=735163
==========

to

==========
VR: Add support for time-aware unit tests.

Add an initial unit test for the transient WebVR warning. This CL is a
lead-in to pulling common transient code out of scene manager and
specific elements.

Note that this development seemed to expose a bug in the mock task
runner, in conjunction with timers. This bug is now blocked on that
bug.

BUG=735163

Review-Url: https://codereview.chromium.org/2960533002
Cr-Commit-Position: refs/heads/master@{#482294}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f5d2f7b0721ace2fcbe408d8374...
==========

[commit-bot: I haz the power, 2017-06-26 16:39:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f5d2f7b0721ace2fcbe408d8374...