VR: Add support for time-aware unit tests.

chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
-#include "base/test/scoped_task_environment.h"
+#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_mock_time_message_loop_task_runner.h"
 #include "chrome/browser/android/vr_shell/ui_browser_interface.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h"
 #include "chrome/browser/android/vr_shell/ui_scene.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace vr_shell {
 
 namespace {
@@ skipping 75 matching lines @@
                         bool visible) {
     for (const auto& element : scene_->GetUiElements()) {
       if (debug_ids.find(element->debug_id()) != debug_ids.end() &&
           element->visible() != visible) {
         return false;
       }
     }
     return true;
   }
 
-  base::test::ScopedTaskEnvironment scoped_task_environment_;
+  base::MessageLoop message_loop_;
+  base::ScopedMockTimeMessageLoopTaskRunner task_runner_;

[bshe, 2017/06/26 15:40:17]

optional nit: should we define this in the test that are time aware? Not sure
how many other tests need this.

[cjgrant, 2017/06/26 16:26:35]

Done.

   std::unique_ptr<MockBrowserInterface> browser_;
   std::unique_ptr<UiScene> scene_;
   std::unique_ptr<UiSceneManager> manager_;
 };
 
 TEST_F(UiSceneManagerTest, ExitPresentAndFullscreenOnAppButtonClick) {
   MakeManager(kNotInCct, kInWebVr);
 
   // Clicking app button should trigger to exit presentation.
   EXPECT_CALL(*browser_, ExitPresent()).Times(1);
@@ skipping 25 matching lines @@
   MakeManager(kNotInCct, kNotInWebVr);
 
   EXPECT_FALSE(IsVisible(kWebVrPermanentHttpSecurityWarning));
   EXPECT_FALSE(IsVisible(kWebVrTransientHttpSecurityWarning));
 
   manager_->SetWebVrMode(true, false, false);
   EXPECT_TRUE(IsVisible(kWebVrPermanentHttpSecurityWarning));
   EXPECT_TRUE(IsVisible(kWebVrTransientHttpSecurityWarning));
 }
 
+TEST_F(UiSceneManagerTest, WebVrTransientWarningTimesOut) {
+  MakeManager(kNotInCct, kInWebVr);
+
+  EXPECT_TRUE(IsVisible(kWebVrTransientHttpSecurityWarning));
+  // TODO(crbug.com/736558): Fast forwarding appears broken in conjunction with

[ymalik, 2017/06/26 14:55:21]

Nit: Spoke offline, since there's nothing actionable here, probably make this a
note?

[cjgrant, 2017/06/26 16:26:35]

Done.  And improved the explanation.

+  // restarting timers. Here, we can fast forward by the appropriate time
+  // interval, but in other cases (until the bug is addressed), we could fast
+  // forward until all tasks are addresed.
+  task_runner_->FastForwardBy(base::TimeDelta::FromSeconds(31));
+  EXPECT_FALSE(IsVisible(kWebVrTransientHttpSecurityWarning));
+}
+
 TEST_F(UiSceneManagerTest, ToastVisibility) {
   // Tests toast not showing when directly entering VR though WebVR
   // presentation.
   MakeManager(kNotInCct, kInWebVr);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   MakeManager(kNotInCct, kNotInWebVr);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   manager_->SetFullscreen(true);
@@ skipping 244 matching lines @@
 
   // Ensure they can be turned off.
   manager_->SetAudioCapturingIndicator(false);
   manager_->SetVideoCapturingIndicator(false);
   manager_->SetScreenCapturingIndicator(false);
   manager_->SetLocationAccessIndicator(false);
   EXPECT_TRUE(VerifyVisibility(indicators, false));
 }
 
 }  // namespace vr_shell