Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 2960273002: enable gold for chromeos build. (Closed)

Created:
3 years, 5 months ago by yunlian
Modified:
3 years, 5 months ago
Reviewers:
llozano, Nico, pcc1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

enable gold for chromeos build. When I try to enable thinlto on ChromeOS build, I hit this assert. This CL fixes that. BUG=None TEST=USE="thinlto" emerge-terra chromeos-chrome, the assertion is gone. Review-Url: https://codereview.chromium.org/2960273002 Cr-Commit-Position: refs/heads/master@{#488345} Committed: https://chromium.googlesource.com/chromium/src/+/d6e3b19d46bfb5ea4c4f7d79b665457c2e66f5ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
yunlian
ping?
3 years, 5 months ago (2017-07-20 17:45:17 UTC) #3
pcc1
lgtm, but I'm not an OWNER. Adding thakis@.
3 years, 5 months ago (2017-07-20 17:48:17 UTC) #5
Nico
lgtm
3 years, 5 months ago (2017-07-20 17:49:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960273002/1
3 years, 5 months ago (2017-07-20 17:54:16 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 19:12:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6e3b19d46bfb5ea4c4f7d79b665...

Powered by Google App Engine
This is Rietveld 408576698