build/config/compiler/BUILD.gn - Issue 2960273002: enable gold for chromeos build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2960273002: enable gold for chromeos build. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index d6392d1df7b2618bd3a7ba5a86129f039aa9babb..e5cd25ada1d8199bbff60a40aa666015cfc44a26 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -481,7 +481,7 @@ config("compiler") {

# TODO(pcc): Make this conditional on is_official_build rather than on gn

# flags for specific features.

if (!is_debug && (allow_posix_link_time_opt || is_cfi) && !is_nacl) {

- assert(use_lld || is_chromeos, "gold plugin only supported with ChromeOS")

+ assert(use_lld || target_os == "chromeos", "gold plugin only supported with ChromeOS")

if (use_thin_lto) {

cflags += [ "-flto=thin" ]

« no previous file with comments | « no previous file | no next file » | no next file with comments »