[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

This is in preparation for relayout zero-block-size floats quirk.

For an aborted layout we don't want the NGLayoutResult to have a Fragment
associated with it, but we do want a BfcOffset, and EndMarginStrut.

This also cleans up double vector for out-of-flow positioned descendants, while
I was there.

BUG=635619
Review-Url: https://codereview.chromium.org/2960233002
Cr-Commit-Position: refs/heads/master@{#483422}
Committed: https://chromium.googlesource.com/chromium/src/+/a0782d6a6407c627004bac723cf73751d8fec130

[ikilpatrick, 2017-06-28 16:13:11]

Description was changed from

==========
[LayoutNG] Move things around.

BUG=
==========

to

==========
[LayoutNG] Move things around.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[ikilpatrick, 2017-06-28 18:26:33]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 18:27:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-06-28 18:29:45]

Description was changed from

==========
[LayoutNG] Move things around.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

This is in preparation for relayout zero-block-size floats quirk.

For an aborted layout we don't want the NGLayoutResult to have a Fragment
associated with it, but we do want a BfcOffset, and EndMarginStrut.

This also cleans up double vector for out-of-flow positioned descendants, while
I was there.

BUG=635619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[ikilpatrick, 2017-06-28 18:30:04]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org

[ikilpatrick, 2017-06-28 18:31:01]

https://codereview.chromium.org/2960233002/diff/2/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_oof_positioned_descendant.h
(right):

https://codereview.chromium.org/2960233002/diff/2/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_oof_positioned_descendant.h:25:
struct CORE_EXPORT NGOOFPositionedDescendant {
I can also name this NGOutOfFlowPositionedDescendant - other suggestions
welcome.

[eae, 2017-06-28 18:31:53]

LGTM

[commit-bot: I haz the power, 2017-06-28 19:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 19:04:43]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger, 2017-06-28 19:27:47]

lgtm

[ikilpatrick, 2017-06-28 20:15:52]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 20:16:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-06-28 21:21:49]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 21:22:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 21:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 21:28:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[ikilpatrick, 2017-06-28 22:59:12]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 22:59:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 00:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 00:43:11]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[ikilpatrick, 2017-06-29 01:01:16]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-06-29 01:01:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2960233002/#ps70001
(title: "OOF -> OutOfFlow")

[commit-bot: I haz the power, 2017-06-29 01:01:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 02:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 02:43:32]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[ikilpatrick, 2017-06-29 14:57:36]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 14:57:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 16:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 16:08:05]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ikilpatrick, 2017-06-29 16:12:02]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 16:12:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-06-29 17:48:02]

Description was changed from

==========
[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

This is in preparation for relayout zero-block-size floats quirk.

For an aborted layout we don't want the NGLayoutResult to have a Fragment
associated with it, but we do want a BfcOffset, and EndMarginStrut.

This also cleans up double vector for out-of-flow positioned descendants, while
I was there.

BUG=635619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

This is in preparation for relayout zero-block-size floats quirk.

For an aborted layout we don't want the NGLayoutResult to have a Fragment
associated with it, but we do want a BfcOffset, and EndMarginStrut.

This also cleans up double vector for out-of-flow positioned descendants, while
I was there.

BUG=635619
==========

[ikilpatrick, 2017-06-29 17:48:29]

removing ng-bot, failures are fixed by:
https://codereview.chromium.org/2969433002/

[ikilpatrick, 2017-06-29 17:48:40]

The CQ bit was unchecked by ikilpatrick@chromium.org

[ikilpatrick, 2017-06-29 17:48:45]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-06-29 17:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2960233002/#ps110001
(title: "OOF -> OutOfFlow")

[commit-bot: I haz the power, 2017-06-29 17:49:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 18:08:28]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1498758525267830,
"parent_rev": "894d66f402ebb97afe82052fa834612feffa8e28", "commit_rev":
"a0782d6a6407c627004bac723cf73751d8fec130"}

[commit-bot: I haz the power, 2017-06-29 18:08:44]

Description was changed from

==========
[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

This is in preparation for relayout zero-block-size floats quirk.

For an aborted layout we don't want the NGLayoutResult to have a Fragment
associated with it, but we do want a BfcOffset, and EndMarginStrut.

This also cleans up double vector for out-of-flow positioned descendants, while
I was there.

BUG=635619
==========

to

==========
[LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

This is in preparation for relayout zero-block-size floats quirk.

For an aborted layout we don't want the NGLayoutResult to have a Fragment
associated with it, but we do want a BfcOffset, and EndMarginStrut.

This also cleans up double vector for out-of-flow positioned descendants, while
I was there.

BUG=635619

Review-Url: https://codereview.chromium.org/2960233002
Cr-Commit-Position: refs/heads/master@{#483422}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0782d6a6407c627004bac723cf7...
==========

[commit-bot: I haz the power, 2017-06-29 18:08:45]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/a0782d6a6407c627004bac723cf7...