third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h - Issue 2960233002: [LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2960233002: [LayoutNG] Move bfc_offset_, end_margin_sturt_ to NGLayoutResult (Closed)

Patch Set: OOF -> OutOfFlow Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

index 1e1a58403a437cc31c8b586ee80bae0fe3eaf444..f93787e18efd67a17a5773842dbf62c8e62f35b4 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

@@ -94,7 +94,7 @@ class CORE_EXPORT NGBlockLayoutAlgorithm

const NGConstraintSpace& child_space);

// Positions the fragment that knows its BFC offset.

- NGLogicalOffset PositionWithBfcOffset(const NGBoxFragment&);

+ NGLogicalOffset PositionWithBfcOffset(const NGLogicalOffset& bfc_offset);

// Positions using the parent BFC offset.

// Fragment doesn't know its offset but we can still calculate its BFC

@@ -105,7 +105,7 @@ class CORE_EXPORT NGBlockLayoutAlgorithm

// <div id="empty-div" style="margins: 1px"></div>

NGLogicalOffset PositionWithParentBfc(const NGConstraintSpace&,

const NGInflowChildData& child_data,

- const NGBoxFragment&);

+ const NGLayoutResult&);

NGLogicalOffset PositionLegacy(const NGConstraintSpace& child_space,

const NGInflowChildData& child_data);