Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2960123002: Revert of Replace AllAppsTileItemView with ArrowExpandView (Closed)

Created:
3 years, 5 months ago by benwells
Modified:
3 years, 5 months ago
Reviewers:
xiyuan, weidongg
CC:
chromium-reviews, tfarina, Matt Giuca, newcomer, Qiang(Joe) Xu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace AllAppsTileItemView with ArrowExpandView (patchset #2 id:20001 of https://codereview.chromium.org/2959943003/ ) Reason for revert: Causes memory leak on ASAN LSAN bot, see https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/22001 Original issue's description: > Replace AllAppsTileItemView with ArrowExpandView > > This CL replace the old "All apps" button in start page with a new arrow > expand button. > > specs: > https://screenshot.googleplex.com/PM0rC5nzVvE > https://screenshot.googleplex.com/Qs1T3mHSf2D > > screenshot: > https://screenshot.googleplex.com/RNQS0joM35z > > BUG=735502 > > Review-Url: https://codereview.chromium.org/2959943003 > Cr-Commit-Position: refs/heads/master@{#482767} > Committed: https://chromium.googlesource.com/chromium/src/+/c6f4af3584484510a05497d4f63d1194a6f553d7 TBR=xiyuan@chromium.org,weidongg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=735502 Review-Url: https://codereview.chromium.org/2960123002 Cr-Commit-Position: refs/heads/master@{#482875} Committed: https://chromium.googlesource.com/chromium/src/+/ffbc4fd6a0c2561d40ce890f20975737a7f1262d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -217 lines) Patch
M ui/app_list/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/vector_icons/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/app_list/vector_icons/ic_arrow_up.icon View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/app_list/vector_icons/ic_arrow_up.1x.icon View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/app_list/views/expand_arrow_view.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/app_list/views/expand_arrow_view.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M ui/app_list/views/start_page_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M ui/app_list/views/suggestions_container_view.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
benwells
Created Revert of Replace AllAppsTileItemView with ArrowExpandView
3 years, 5 months ago (2017-06-28 04:03:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960123002/1
3 years, 5 months ago (2017-06-28 04:04:03 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 04:04:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffbc4fd6a0c2561d40ce890f2097...

Powered by Google App Engine
This is Rietveld 408576698