Replace AllAppsTileItemView with ArrowExpandView

Reland: Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502
Review-Url: https://codereview.chromium.org/2959943003
Cr-Commit-Position: refs/heads/master@{#483103}
Committed: https://chromium.googlesource.com/chromium/src/+/7c24da4cdb9052839e6baf3291bd55436981b7b4

[weidongg, 2017-06-27 18:15:50]

weidongg@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-06-27 19:57:06]

lgtm

You probably need to rebase since Joe has moved StartPageTilesContainer out into
its own file.

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
File ui/app_list/views/expand_arrow_view.h (right):

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
ui/app_list/views/expand_arrow_view.h:29: 
nit: get rid of this empty line

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
ui/app_list/views/expand_arrow_view.h:39: protected:
I am okay to just make those below public.

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
ui/app_list/views/expand_arrow_view.h:48: ContentsView* contents_view_;
nit: This can be a const ptr too.
i.e.
  ContentsView* -> ContentsView* const

[weidongg, 2017-06-27 20:41:50]

Thanks for the review, just rebased.

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
File ui/app_list/views/expand_arrow_view.h (right):

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
ui/app_list/views/expand_arrow_view.h:29: 
On 2017/06/27 19:57:06, xiyuan wrote:
> nit: get rid of this empty line

Done.

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
ui/app_list/views/expand_arrow_view.h:39: protected:
On 2017/06/27 19:57:06, xiyuan wrote:
> I am okay to just make those below public.

Done.

https://codereview.chromium.org/2959943003/diff/1/ui/app_list/views/expand_ar...
ui/app_list/views/expand_arrow_view.h:48: ContentsView* contents_view_;
On 2017/06/27 19:57:06, xiyuan wrote:
> nit: This can be a const ptr too.
> i.e.
>   ContentsView* -> ContentsView* const

Done.

[xiyuan, 2017-06-27 21:03:18]

still lgtm

[weidongg, 2017-06-27 21:05:48]

The CQ bit was checked by weidongg@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:06:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 22:47:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498597548016200,
"parent_rev": "695bdb6e4d5737aca24e7bc0cab499d60411874f", "commit_rev":
"c6f4af3584484510a05497d4f63d1194a6f553d7"}

[commit-bot: I haz the power, 2017-06-27 22:47:41]

Description was changed from

==========
Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502
==========

to

==========
Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502

Review-Url: https://codereview.chromium.org/2959943003
Cr-Commit-Position: refs/heads/master@{#482767}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6f4af3584484510a05497d4f63d...
==========

[commit-bot: I haz the power, 2017-06-27 22:47:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c6f4af3584484510a05497d4f63d...

[benwells, 2017-06-28 04:03:51]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2960123002/ by benwells@chromium.org.

The reason for reverting is: Causes memory leak on ASAN LSAN bot, see
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom....

[weidongg, 2017-06-28 17:56:21]

Description was changed from

==========
Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502

Review-Url: https://codereview.chromium.org/2959943003
Cr-Commit-Position: refs/heads/master@{#482767}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6f4af3584484510a05497d4f63d...
==========

to

==========
Reland: Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502
==========

[weidongg, 2017-06-28 18:01:34]

xiyuan@, AllAppsTileItemView is not used in new launcher, I didn't remove the
instantiation of the class. I think that's possibly the reason for memory leak.

[xiyuan, 2017-06-28 18:05:17]

lgtm

[weidongg, 2017-06-28 18:12:18]

The CQ bit was checked by weidongg@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:12:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 19:44:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498673538484820,
"parent_rev": "bf68beb619663b0208826075bd2e8f00e3c65a7d", "commit_rev":
"7c24da4cdb9052839e6baf3291bd55436981b7b4"}

[commit-bot: I haz the power, 2017-06-28 19:44:45]

Description was changed from

==========
Reland: Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502
==========

to

==========
Reland: Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG=735502

Review-Url: https://codereview.chromium.org/2959943003
Cr-Commit-Position: refs/heads/master@{#483103}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c24da4cdb9052839e6baf3291bd...
==========

[commit-bot: I haz the power, 2017-06-28 19:44:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7c24da4cdb9052839e6baf3291bd...