Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2960073002: Generate constants in server as we do in plugin (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : improve names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -282 lines) Patch
M pkg/analysis_server/benchmark/integration/input_converter.dart View 5 chunks +23 lines, -23 lines 0 comments Download
A pkg/analysis_server/lib/protocol/protocol_constants.dart View 1 1 chunk +241 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 3 chunks +0 lines, -121 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analytics.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +13 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 7 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_util.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/edit/is_postfix_completion_applicable_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/edit/list_postfix_completion_templates_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/support/integration_test_methods.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/support/integration_tests.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 5 chunks +8 lines, -5 lines 0 comments Download
A + pkg/analysis_server/tool/spec/codegen_protocol_constants.dart View 1 2 chunks +12 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 1 2 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_protocol_constants.dart View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-06-27 23:38:28 UTC) #2
scheglov
https://codereview.chromium.org/2960073002/diff/1/pkg/analysis_server/lib/protocol/protocol_constants.dart File pkg/analysis_server/lib/protocol/protocol_constants.dart (right): https://codereview.chromium.org/2960073002/diff/1/pkg/analysis_server/lib/protocol/protocol_constants.dart#newcode99 pkg/analysis_server/lib/protocol/protocol_constants.dart:99: const String COMPLETION_NOTIFICATION_RESULTS_ISLAST = 'isLast'; Can we insert "_" ...
3 years, 5 months ago (2017-06-28 01:28:20 UTC) #3
Brian Wilkerson
ptal https://codereview.chromium.org/2960073002/diff/1/pkg/analysis_server/lib/protocol/protocol_constants.dart File pkg/analysis_server/lib/protocol/protocol_constants.dart (right): https://codereview.chromium.org/2960073002/diff/1/pkg/analysis_server/lib/protocol/protocol_constants.dart#newcode100 pkg/analysis_server/lib/protocol/protocol_constants.dart:100: const String COMPLETION_NOTIFICATION_RESULTS_REPLACEMENTLENGTH = Done
3 years, 5 months ago (2017-06-28 14:35:27 UTC) #4
scheglov
LGTM
3 years, 5 months ago (2017-06-28 15:15:07 UTC) #5
Brian Wilkerson
3 years, 5 months ago (2017-06-28 15:21:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9ddb832e103a564fbd3e11f89c40439256d63d61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698