pkg/analysis_server/test/analysis/reanalyze_test.dart - Issue 2960073002: Generate constants in server as we do in plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis/reanalyze_test.dart

Issue 2960073002: Generate constants in server as we do in plugin (Closed)

Patch Set: improve names Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/analysis/notification_overrides_test.dart ('k') | pkg/analysis_server/test/analysis/update_content_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/analysis/reanalyze_test.dart

diff --git a/pkg/analysis_server/test/analysis/reanalyze_test.dart b/pkg/analysis_server/test/analysis/reanalyze_test.dart

index eb0421df327e6898aa2f6c637f27281d8cdbf723..3dab4be3efb2ad67d0acbd323c5fbf6073df6c72 100644

--- a/pkg/analysis_server/test/analysis/reanalyze_test.dart

+++ b/pkg/analysis_server/test/analysis/reanalyze_test.dart

@@ -5,8 +5,8 @@

import 'dart:async';

import 'package:analysis_server/protocol/protocol.dart';

+import 'package:analysis_server/protocol/protocol_constants.dart';

import 'package:analysis_server/protocol/protocol_generated.dart';

-import 'package:analysis_server/src/constants.dart';

import 'package:analyzer_plugin/protocol/protocol_common.dart';

import 'package:test/test.dart';

import 'package:test_reflective_loader/test_reflective_loader.dart';

@@ -27,7 +27,7 @@ class ReanalyzeTest extends AbstractAnalysisTest {

@override

void processNotification(Notification notification) {

- if (notification.event == ANALYSIS_ERRORS) {

+ if (notification.event == ANALYSIS_NOTIFICATION_ERRORS) {

var decoded = new AnalysisErrorsParams.fromNotification(notification);

filesErrors[decoded.file] = decoded.errors;

_resultsAvailable.complete(null);

@@ -38,7 +38,7 @@ class ReanalyzeTest extends AbstractAnalysisTest {

createProject();

Map drivers = server.driverMap;

expect(drivers, hasLength(1));

- Request request = new Request("0", ANALYSIS_REANALYZE);

+ Request request = new Request("0", ANALYSIS_REQUEST_REANALYZE);

handleSuccessfulRequest(request);

drivers = server.driverMap;

expect(drivers, hasLength(1));

@@ -75,7 +75,7 @@ class ReanalyzeTest extends AbstractAnalysisTest {

test_sentToPlugins() async {

createProject();

- Request request = new Request("0", ANALYSIS_REANALYZE);

+ Request request = new Request("0", ANALYSIS_REQUEST_REANALYZE);

handleSuccessfulRequest(request);

// verify

expect(pluginManager.broadcastedRequest, isNotNull);