pkg/analysis_server/test/analysis/notification_highlights_test.dart - Issue 2960073002: Generate constants in server as we do in plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis/notification_highlights_test.dart

Issue 2960073002: Generate constants in server as we do in plugin (Closed)

Patch Set: improve names Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/analysis/notification_errors_test.dart ('k') | pkg/analysis_server/test/analysis/notification_highlights_test2.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/analysis/notification_highlights_test.dart

diff --git a/pkg/analysis_server/test/analysis/notification_highlights_test.dart b/pkg/analysis_server/test/analysis/notification_highlights_test.dart

index 1002cc2f213410fc9bbaeb5e122af478f58ec44b..77d28daa0ddaab16d38a04195876ccfd5a1df5a0 100644

--- a/pkg/analysis_server/test/analysis/notification_highlights_test.dart

+++ b/pkg/analysis_server/test/analysis/notification_highlights_test.dart

@@ -5,8 +5,8 @@

import 'dart:async';

import 'package:analysis_server/protocol/protocol.dart';

+import 'package:analysis_server/protocol/protocol_constants.dart';

import 'package:analysis_server/protocol/protocol_generated.dart';

-import 'package:analysis_server/src/constants.dart';

import 'package:analyzer_plugin/protocol/protocol_common.dart';

import 'package:test/test.dart';

import 'package:test_reflective_loader/test_reflective_loader.dart';

@@ -96,7 +96,7 @@ class AnalysisNotificationHighlightsTest extends AbstractAnalysisTest {

}

void processNotification(Notification notification) {

- if (notification.event == ANALYSIS_HIGHLIGHTS) {

+ if (notification.event == ANALYSIS_NOTIFICATION_HIGHLIGHTS) {

var params = new AnalysisHighlightsParams.fromNotification(notification);

if (params.file == testFile) {

regions = params.regions;