[wasm] Move the CallDescriptor creation methods out of ModuleEnv into the compiler.

[wasm] Move the CallDescriptor creation methods out of ModuleEnv into the compiler.

R=clemensh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2959963002
Cr-Commit-Position: refs/heads/master@{#46263}
Committed: https://chromium.googlesource.com/v8/v8/+/0a91a4c90f28be3a769323f99c95e698b09b0c09

[titzer, 2017-06-27 11:42:12]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 11:42:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 11:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 11:53:32]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[titzer, 2017-06-27 12:14:24]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 12:14:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-06-27 12:18:02]

lgtm

[commit-bot: I haz the power, 2017-06-27 12:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 12:19:42]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jochen (gone - plz use gerrit), 2017-06-27 14:25:02]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-06-27 14:25:03]

why are the declarations in wasm-compiler.h but the definitions in
wasm-linkage.cc (which doesn't include wasm-compiler.h)?

[titzer, 2017-06-27 14:26:41]

On 2017/06/27 14:25:03, jochen wrote:
> why are the declarations in wasm-compiler.h but the definitions in
> wasm-linkage.cc (which doesn't include wasm-compiler.h)?

I know this is against convention and we probably should fix it. 
The reason is that wasm-compiler.h is the only "legal" include from the compiler
directory into the wasm directory.

[titzer, 2017-06-27 14:28:35]

On 2017/06/27 14:26:41, titzer wrote:
> On 2017/06/27 14:25:03, jochen wrote:
> > why are the declarations in wasm-compiler.h but the definitions in
> > wasm-linkage.cc (which doesn't include wasm-compiler.h)?
> 
> I know this is against convention and we probably should fix it. 
> The reason is that wasm-compiler.h is the only "legal" include from the
compiler
> directory into the wasm directory.

We could, e.g., introduce a wasm-linkage.h header, since these functions are
only used in the compiler, but I don't think that impacts the underlying link
problem that popped up on Windows.

[jochen (gone - plz use gerrit), 2017-06-27 14:30:23]

maybe include wasm-compiler.h from wasm-linkage.cc? does that fix the problem?

[titzer, 2017-06-27 15:03:48]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 15:03:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 15:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 15:31:07]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-06-27 15:36:38]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-06-27 15:36:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org
Link to the patchset: https://codereview.chromium.org/2959963002/#ps40001
(title: "Include wasm-compiler.h from wasm-linkage.cc")

[commit-bot: I haz the power, 2017-06-27 15:36:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 15:38:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498577798603700,
"parent_rev": "5dd179933c32b0ea992b53b6fc82db0b88a85734", "commit_rev":
"0a91a4c90f28be3a769323f99c95e698b09b0c09"}

[commit-bot: I haz the power, 2017-06-27 15:39:06]

Description was changed from

==========
[wasm] Move the CallDescriptor creation methods out of ModuleEnv into the
compiler.

R=clemensh@chromium.org
BUG=
==========

to

==========
[wasm] Move the CallDescriptor creation methods out of ModuleEnv into the
compiler.

R=clemensh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2959963002
Cr-Commit-Position: refs/heads/master@{#46263}
Committed:
https://chromium.googlesource.com/v8/v8/+/0a91a4c90f28be3a769323f99c95e698b09...
==========

[commit-bot: I haz the power, 2017-06-27 15:39:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0a91a4c90f28be3a769323f99c95e698b09...