Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: src/wasm/wasm-module.h

Issue 2959963002: [wasm] Move the CallDescriptor creation methods out of ModuleEnv into the compiler. (Closed)
Patch Set: Include wasm-compiler.h from wasm-linkage.cc Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/module-compiler.h ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 5e7c86c04b9913f0413e60859c20482eece2fcf4..b61f0d8de153b4a1d771bbd6041c8cb62877a33f 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -162,15 +162,12 @@ struct V8_EXPORT_PRIVATE WasmModule {
static const uint32_t kMinMemPages = 1; // Minimum memory size = 64kb
std::unique_ptr<Zone> signature_zone;
- uint32_t min_mem_pages = 0; // minimum size of the memory in 64k pages
- uint32_t max_mem_pages = 0; // maximum size of the memory in 64k pages
- bool has_max_mem = false; // try if a maximum memory size exists
- bool has_memory = false; // true if the memory was defined or imported
- bool mem_export = false; // true if the memory is exported
- // TODO(wasm): reconcile start function index being an int with
- // the fact that we index on uint32_t, so we may technically not be
- // able to represent some start_function_index -es.
- int start_function_index = -1; // start function, if any
+ uint32_t min_mem_pages = 0; // minimum size of the memory in 64k pages
+ uint32_t max_mem_pages = 0; // maximum size of the memory in 64k pages
+ bool has_max_mem = false; // try if a maximum memory size exists
+ bool has_memory = false; // true if the memory was defined or imported
+ bool mem_export = false; // true if the memory is exported
+ int start_function_index = -1; // start function, >= 0 if any
std::vector<WasmGlobal> globals; // globals in this module.
uint32_t globals_size = 0; // size of globals table.
@@ -365,14 +362,6 @@ struct V8_EXPORT_PRIVATE ModuleEnv {
DCHECK_NOT_NULL(instance);
return instance->function_code[index];
}
-
- // TODO(titzer): move these into src/compiler/wasm-compiler.cc
- static compiler::CallDescriptor* GetWasmCallDescriptor(Zone* zone,
- FunctionSig* sig);
- static compiler::CallDescriptor* GetI32WasmCallDescriptor(
- Zone* zone, compiler::CallDescriptor* descriptor);
- static compiler::CallDescriptor* GetI32WasmCallDescriptorForSimd(
- Zone* zone, compiler::CallDescriptor* descriptor);
};
// A ModuleEnv together with ModuleWireBytes.
« no previous file with comments | « src/wasm/module-compiler.h ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698