Fix GetHostNameWithHTTPScheme for IPv6 addresses

Fix GetHostNameWithHTTPScheme for IPv6 addresses

BUG=736324
Review-Url: https://codereview.chromium.org/2959443003
Cr-Commit-Position: refs/heads/master@{#481905}
Committed: https://chromium.googlesource.com/chromium/src/+/ab4e009f7069ddb500a1ad4503cb19a3a9018458

[Jialiu Lin, 2017-06-23 14:03:13]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 14:03:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-23 14:05:05]

jialiul@chromium.org changed reviewers:
+ ricea@chromium.org

[Jialiu Lin, 2017-06-23 14:05:06]

Hi ricea@, 
Thanks for pointing out these problems.  Let me know if you have additional
comments.

Thanks!

[Adam Rice, 2017-06-23 14:10:20]

Quick work! lgtm.

I did notice that in the test file there is this test:

  EXPECT_FALSE(PasswordProtectionService::CanGetReputationOfURL(
      GURL("http://FEED::BEEF")));

This test actually passes because CanGetReputationOfURL() returns false for an
invalid URL, which is maybe not what was intended. Probably
"http://[FEED::BEEF]" would be better.

[Jialiu Lin, 2017-06-23 14:24:31]

Thanks for catching this!  unit test fixed. :-)

[Adam Rice, 2017-06-23 14:31:37]

unit test also lgtm

[Jialiu Lin, 2017-06-23 14:43:34]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2017-06-23 14:43:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 15:57:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498229014442830,
"parent_rev": "2b4bf663954310f6bd0227aa93071958c5dbf53a", "commit_rev":
"303924f1282222e7b9c86c1134f2f7ba61b4d53e"}

[commit-bot: I haz the power, 2017-06-23 15:57:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498229014442830,
"parent_rev": "aefd605c21331b94e8e8cce0daac64f9a944e9af", "commit_rev":
"ab4e009f7069ddb500a1ad4503cb19a3a9018458"}

[commit-bot: I haz the power, 2017-06-23 15:57:36]

Description was changed from

==========
Fix GetHostNameWithHTTPScheme for IPv6 addresses

BUG=736324
==========

to

==========
Fix GetHostNameWithHTTPScheme for IPv6 addresses

BUG=736324

Review-Url: https://codereview.chromium.org/2959443003
Cr-Commit-Position: refs/heads/master@{#481905}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab4e009f7069ddb500a1ad4503cb...
==========

[commit-bot: I haz the power, 2017-06-23 15:57:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab4e009f7069ddb500a1ad4503cb...