components/safe_browsing/password_protection/password_protection_service_unittest.cc - Issue 2959443003: Fix GetHostNameWithHTTPScheme for IPv6 addresses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/password_protection/password_protection_service_unittest.cc

Issue 2959443003: Fix GetHostNameWithHTTPScheme for IPv6 addresses (Closed)

Patch Set: fix unittest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/safe_browsing/password_protection/password_protection_service_unittest.cc

diff --git a/components/safe_browsing/password_protection/password_protection_service_unittest.cc b/components/safe_browsing/password_protection/password_protection_service_unittest.cc

index fb61afd5bb5940f5b6c4ef380dee77a861ab4adc..578fe9362df00447e609c6308f40334cc0362bf2 100644

--- a/components/safe_browsing/password_protection/password_protection_service_unittest.cc

+++ b/components/safe_browsing/password_protection/password_protection_service_unittest.cc

@@ -431,7 +431,7 @@ TEST_F(PasswordProtectionServiceTest, VerifyCanGetReputationOfURL) {

EXPECT_FALSE(PasswordProtectionService::CanGetReputationOfURL(

GURL("http://10.0.1.0/")));

EXPECT_FALSE(PasswordProtectionService::CanGetReputationOfURL(

- GURL("http://FEED::BEEF")));

+ GURL("http://[FEED::BEEF]")));

// Main frame URL is a no-yet-assigned y ICANN gTLD.

EXPECT_FALSE(PasswordProtectionService::CanGetReputationOfURL(

« no previous file with comments | « components/safe_browsing/password_protection/password_protection_service.cc ('k') | no next file » | no next file with comments »