color: Read all displays' color profiles on Windows

color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Remove the ScreenWin::Initialize virtual method because, being called
from the constructor, being virtual had no effect. Replace with a
constructor argument to call initialize.

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

TBR=hubbe
BUG=735613
Review-Url: https://codereview.chromium.org/2959423003
Cr-Commit-Position: refs/heads/master@{#484376}
Committed: https://chromium.googlesource.com/chromium/src/+/8f608ad3382a72a4d11489fccbe895c473ae9992

[ccameron, 2017-06-30 00:47:34]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2017-06-30 00:47:35]

ptal -- almost to the point of having multi-monitor working on Windows

I didn't actually change any behavior because I'm afraid of bugs from when I
do...

[ccameron, 2017-07-02 06:52:24]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-02 06:52:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shaunmoav, 2017-07-02 07:37:40]

On 2017/06/30 00:47:35, ccameron wrote:
> ptal -- almost to the point of having multi-monitor working on Windows
> 
> I didn't actually change any behavior because I'm afraid of bugs from when I
> do...

Gmail

[ccameron, 2017-07-02 07:57:15]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-02 07:57:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-02 08:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-02 08:28:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[ccameron, 2017-07-02 08:41:42]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-02 08:41:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-07-02 08:46:38]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-07-02 09:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-02 09:41:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2017-07-05 01:31:52]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 01:32:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-07-05 01:32:29]

Description was changed from

==========
color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

BUG=735613
==========

to

==========
color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Remove the ScreenWin::Initialize virtual method because, being called
from the constructor, being virtual had no effect. Replace with a
constructor argument to call initialize.

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

BUG=735613
==========

[commit-bot: I haz the power, 2017-07-05 02:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 02:34:06]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[ccameron, 2017-07-05 18:22:56]

ping

[ccameron, 2017-07-05 21:22:29]

Description was changed from

==========
color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Remove the ScreenWin::Initialize virtual method because, being called
from the constructor, being virtual had no effect. Replace with a
constructor argument to call initialize.

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

BUG=735613
==========

to

==========
color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Remove the ScreenWin::Initialize virtual method because, being called
from the constructor, being virtual had no effect. Replace with a
constructor argument to call initialize.

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

TBR=hubbe
BUG=735613
==========

[ccameron, 2017-07-05 23:27:11]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-07-05 23:27:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 00:07:50]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499297231284440,
"parent_rev": "8a7bc355a63b004a3acb2567d66ce443a98d12ea", "commit_rev":
"8f608ad3382a72a4d11489fccbe895c473ae9992"}

[commit-bot: I haz the power, 2017-07-06 00:08:11]

Description was changed from

==========
color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Remove the ScreenWin::Initialize virtual method because, being called
from the constructor, being virtual had no effect. Replace with a
constructor argument to call initialize.

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

TBR=hubbe
BUG=735613
==========

to

==========
color: Read all displays' color profiles on Windows

This restores code that was unused and removed in crrev.com/334309.

Enumerate all monitors, and read all of their ICC profiles, instead of
just reading the profile for the "best monitor".

Remove the ScreenWin::Initialize virtual method because, being called
from the constructor, being virtual had no effect. Replace with a
constructor argument to call initialize.

Don't actually hook any of this up yet -- still only return the profile
for the "best monitor", but do that by looking it up in the full cache
that has been built.

TBR=hubbe
BUG=735613

Review-Url: https://codereview.chromium.org/2959423003
Cr-Commit-Position: refs/heads/master@{#484376}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f608ad3382a72a4d11489fccbe8...
==========

[commit-bot: I haz the power, 2017-07-06 00:08:12]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8f608ad3382a72a4d11489fccbe8...