[Cronet] Use gn desc to find third party licenses on Android.

[Cronet] Use gn desc to find third party licenses on Android.

Filter out build/secondary/third_party dependencies to work around 
__main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in build/secondary/third_party/android_tools

BUG=606859
BUG=710801
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2959303002
Cr-Commit-Position: refs/heads/master@{#485291}
Committed: https://chromium.googlesource.com/chromium/src/+/0fd5121f8fe912464b4f4d46dbb90d6209f59bf0

[mef, 2017-06-28 21:28:21]

Description was changed from

==========
[Cronet] Use gn desc to find third party licenses on Android.
Filter out build/secondary/third_party dependencies.

BUG=606859
==========

to

==========
[Cronet] Use gn desc to find third party licenses on Android.
Filter out build/secondary/third_party dependencies.

BUG=606859
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2017-06-28 21:29:14]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 21:29:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-06-28 21:33:33]

Description was changed from

==========
[Cronet] Use gn desc to find third party licenses on Android.
Filter out build/secondary/third_party dependencies.

BUG=606859
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Use gn desc to find third party licenses on Android.
Filter out build/secondary/third_party dependencies.

BUG=606859
BUG=710801
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2017-06-28 21:33:34]

mef@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[mef, 2017-06-28 21:36:53]

mef@chromium.org changed reviewers:
+ ichikawa@chromium.org

[mef, 2017-06-28 21:36:54]

Hi Pawel, PTAL. This is followup to discussion on
https://codereview.chromium.org/2797403002/ to use licenses.py and gn deps to
generate LICENSES for Cronet on Android.

Is it possible to have licenses sorted by project name? 
I'm afraid that without sorting we may end up with spurious diffs.

[commit-bot: I haz the power, 2017-06-28 23:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 23:14:17]

Dry run: This issue passed the CQ dry run.

[Hiroshi Ichikawa, 2017-06-29 02:43:35]

lgtm

Sorry I said I will do this but I never had time...

[Paweł Hajdan Jr., 2017-06-30 07:16:05]

https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py
File tools/licenses.py (right):

https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py#newcode496
tools/licenses.py:496: # TODO(phajdan): Consider using PRUNE_PATHS to filter
unwanted deps.
Why does this TODO add me? It should add the person who has more context... you?
;-)

[mef, 2017-06-30 12:38:41]

https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py
File tools/licenses.py (right):

https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py#newcode496
tools/licenses.py:496: # TODO(phajdan): Consider using PRUNE_PATHS to filter
unwanted deps.
On 2017/06/30 07:16:05, Paweł Hajdan Jr. wrote:
> Why does this TODO add me? It should add the person who has more context...
you?
> ;-)

I'll be happy to leave it as is or use PRUNE_PATHS if that makes sense, which I
don't know. 
Do you know, who is a proper person to ask?

The technical difficulty I ran into here is that PRUNE_PATHS contain relative
paths, but |build_dep| contains the absolute one, so naive 'build_dep in
PRUNE_PATHS' doesn't work.

[mef, 2017-06-30 14:31:46]

https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py
File tools/licenses.py (right):

https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py#newcode496
tools/licenses.py:496: # TODO(phajdan): Consider using PRUNE_PATHS to filter
unwanted deps.
On 2017/06/30 12:38:40, mef wrote:
> On 2017/06/30 07:16:05, Paweł Hajdan Jr. wrote:
> > Why does this TODO add me? It should add the person who has more context...
> you?
> > ;-)
> 
> I'll be happy to leave it as is or use PRUNE_PATHS if that makes sense, which
I
> don't know. 
> Do you know, who is a proper person to ask?
> 
> The technical difficulty I ran into here is that PRUNE_PATHS contain relative
> paths, but |build_dep| contains the absolute one, so naive 'build_dep in
> PRUNE_PATHS' doesn't work.

I've played with relpath and PRUNE_PATHS and it looks ugly.
The problematic directory is 'build/secondary/third_party/android_tools' so
naive check for it being in PRUNE_PATHS doesn't work.

I think that current check is reasonably good and can stay. WDYT?

[mef, 2017-06-30 15:05:45]

mef@chromium.org changed reviewers:
+ xunjieli@chromium.org

[mef, 2017-06-30 15:07:26]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 15:07:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 16:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 16:29:56]

Dry run: This issue passed the CQ dry run.

[mef, 2017-07-05 15:21:25]

On 2017/06/30 14:31:46, mef wrote:
> https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py
> File tools/licenses.py (right):
> 
> https://codereview.chromium.org/2959303002/diff/1/tools/licenses.py#newcode496
> tools/licenses.py:496: # TODO(phajdan): Consider using PRUNE_PATHS to filter
> unwanted deps.
> On 2017/06/30 12:38:40, mef wrote:
> > On 2017/06/30 07:16:05, Paweł Hajdan Jr. wrote:
> > > Why does this TODO add me? It should add the person who has more
context...
> > you?
> > > ;-)
> > 
> > I'll be happy to leave it as is or use PRUNE_PATHS if that makes sense,
which
> I
> > don't know. 
> > Do you know, who is a proper person to ask?
> > 
> > The technical difficulty I ran into here is that PRUNE_PATHS contain
relative
> > paths, but |build_dep| contains the absolute one, so naive 'build_dep in
> > PRUNE_PATHS' doesn't work.
> 
> I've played with relpath and PRUNE_PATHS and it looks ugly.
> The problematic directory is 'build/secondary/third_party/android_tools' so
> naive check for it being in PRUNE_PATHS doesn't work.
> 
> I think that current check is reasonably good and can stay. WDYT?

Hi Pawel, friendly ping, PTAL, WDYT?

[mef, 2017-07-10 14:55:54]

Description was changed from

==========
[Cronet] Use gn desc to find third party licenses on Android.
Filter out build/secondary/third_party dependencies.

BUG=606859
BUG=710801
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Use gn desc to find third party licenses on Android.

Filter out build/secondary/third_party dependencies to work around 
__main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES
entry in build/secondary/third_party/android_tools

BUG=606859
BUG=710801
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2017-07-10 14:56:36]

PTAL.

[Paweł Hajdan Jr., 2017-07-10 15:01:25]

LGTM

[mef, 2017-07-10 15:02:19]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 15:02:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-07-10 15:06:46]

lgtm

[commit-bot: I haz the power, 2017-07-10 16:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 16:23:29]

Dry run: This issue passed the CQ dry run.

[mef, 2017-07-10 16:24:40]

The CQ bit was checked by mef@chromium.org

[mef, 2017-07-10 16:24:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
ichikawa@chromium.org
Link to the patchset: https://codereview.chromium.org/2959303002/#ps60001
(title: "Use single quotes.")

[commit-bot: I haz the power, 2017-07-10 16:24:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 16:30:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499703880852860,
"parent_rev": "b891953a093ee5ab2f78df398322e6cf59c7c2e6", "commit_rev":
"0fd5121f8fe912464b4f4d46dbb90d6209f59bf0"}

[commit-bot: I haz the power, 2017-07-10 16:30:51]

Description was changed from

==========
[Cronet] Use gn desc to find third party licenses on Android.

Filter out build/secondary/third_party dependencies to work around 
__main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES
entry in build/secondary/third_party/android_tools

BUG=606859
BUG=710801
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Use gn desc to find third party licenses on Android.

Filter out build/secondary/third_party dependencies to work around 
__main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES
entry in build/secondary/third_party/android_tools

BUG=606859
BUG=710801
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2959303002
Cr-Commit-Position: refs/heads/master@{#485291}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fd5121f8fe912464b4f4d46dbb9...
==========

[commit-bot: I haz the power, 2017-07-10 16:30:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0fd5121f8fe912464b4f4d46dbb9...