tools/licenses.py - Issue 2959303002: [Cronet] Use gn desc to find third party licenses on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/licenses.py

Issue 2959303002: [Cronet] Use gn desc to find third party licenses on Android. (Closed)

Patch Set: Use single quotes. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/licenses.py

diff --git a/tools/licenses.py b/tools/licenses.py

index 9f33ffb8450ef0e440658c997302b3c55a904bf1..ee65177cb96aed73d60f3617ee6df9c49b91253f 100755

--- a/tools/licenses.py

+++ b/tools/licenses.py

@@ -493,7 +493,7 @@ def GetThirdPartyDepsFromGNDepsOutput(gn_deps):

third_party_deps = set()

for build_dep in gn_deps.split():

m = re.search(r'^(.+/third_party/[^/]+)/(.+/)?BUILD\.gn$', build_dep)

- if m:

+ if m and not os.path.join('build', 'secondary') in build_dep:

third_party_deps.add(m.group(1))

return third_party_deps

« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | no next file » | no next file with comments »