Show corresponding window/widget/view in UIElement tree when clicking on a UI element.

Migrating to https://chromium-review.googlesource.com/c/582927/

BUG=736855

[thanhph, 2017-06-28 20:30:27]

Description was changed from

==========
Show corresponding window/widget/view in UIElement tree when hovered.

BUG=736855
==========

to

==========
WIP: Show corresponding window/widget/view in UIElement tree when hovered.

BUG=736855
==========

[thanhph, 2017-07-05 13:23:52]

Description was changed from

==========
WIP: Show corresponding window/widget/view in UIElement tree when hovered.

BUG=736855
==========

to

==========
WIP: Show corresponding window/widget/view in UIElement tree when clicking on UI
elements.

BUG=736855
==========

[thanhph, 2017-07-05 13:24:45]

Description was changed from

==========
WIP: Show corresponding window/widget/view in UIElement tree when clicking on UI
elements.

BUG=736855
==========

to

==========
WIP: Show corresponding window/widget/view in UIElement tree when clicking on a
UI element.

BUG=736855
==========

[thanhph, 2017-07-05 15:51:15]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 15:51:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 16:22:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 16:22:53]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sadrul, 2017-07-13 20:17:19]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-07-13 20:17:20]

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:121: const int y,
Take a const gfx::Point& as the location input.

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:129: bounds.bottom() >= y
&&
Use gfx::Rect::Contains(gfx::Point)

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:132: *min_bounds =
bounds.width() + bounds.height();
I don't understand why you need |min_bounds| here.

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:259:
FindElement(window_element_root_.get(), event->location().x(),
event->location() is in the coordinate space of |event->target()| window, not
the root window. So using |window_element_root_.get()| here is wrong. You should
either:

 1. Send event->root_location() to FindElement(). or,
 2. Find the UIElement corresponding to event->target(), and send that (with
event->location()) to FindElement().

2 is the better option. So let's try that first.

[thanhph, 2017-07-14 16:58:41]

Patchset #8 (id:140001) has been deleted

[thanhph, 2017-07-14 16:59:47]

Thanks, Sadrul. I addressed your comments in this latest patch, still need to
send correct Overlay message.

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:121: const int y,
On 2017/07/13 20:17:20, sadrul wrote:
> Take a const gfx::Point& as the location input.

Done.

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:129: bounds.bottom() >= y
&&
On 2017/07/13 20:17:20, sadrul wrote:
> Use gfx::Rect::Contains(gfx::Point)

Done.

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:132: *min_bounds =
bounds.width() + bounds.height();
On 2017/07/13 20:17:20, sadrul wrote:
> I don't understand why you need |min_bounds| here.

Acknowledged. We just select the deepest element in pre-order during DFS. I
renamed the function to FindTighterBoundUIElement().

https://codereview.chromium.org/2959263002/diff/100001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:259:
FindElement(window_element_root_.get(), event->location().x(),
On 2017/07/13 20:17:20, sadrul wrote:
> event->location() is in the coordinate space of |event->target()| window, not
> the root window. So using |window_element_root_.get()| here is wrong. You
should
> either:
> 
>  1. Send event->root_location() to FindElement(). or,
>  2. Find the UIElement corresponding to event->target(), and send that (with
> event->location()) to FindElement().
> 
> 2 is the better option. So let's try that first.

I picked the 1st approach.

[thanhph, 2017-07-19 21:26:59]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 21:27:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-07-19 22:03:02]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 22:03:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-07-19 22:19:28]

Patchset #1 (id:1) has been deleted

[thanhph, 2017-07-19 22:19:35]

Patchset #1 (id:20001) has been deleted

[thanhph, 2017-07-19 22:19:42]

Patchset #1 (id:40001) has been deleted

[thanhph, 2017-07-19 22:19:48]

Patchset #1 (id:60001) has been deleted

[thanhph, 2017-07-19 22:20:00]

Patchset #1 (id:80001) has been deleted

[thanhph, 2017-07-19 22:20:07]

Patchset #5 (id:200001) has been deleted

[thanhph, 2017-07-19 22:20:21]

Patchset #2 (id:120001) has been deleted

[thanhph, 2017-07-19 22:34:38]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 22:35:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-07-19 22:35:16]

Thanks Sadrul. You can review my latest patch.

Thanh.

[commit-bot: I haz the power, 2017-07-20 00:35:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 00:35:47]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-07-21 14:59:41]

Patchset #10 (id:340001) has been deleted

[thanhph, 2017-07-24 13:43:27]

Description was changed from

==========
WIP: Show corresponding window/widget/view in UIElement tree when clicking on a
UI element.

BUG=736855
==========

to

==========
Migrating to https://chromium-review.googlesource.com/c/582927/

BUG=736855
==========