Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: components/ui_devtools/views/ui_devtools_dom_agent.h

Issue 2959263002: Show corresponding window/widget/view in UIElement tree when clicking on a UI element. (Closed)
Patch Set: set handled for cancelable event mouse click Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ui_devtools/views/BUILD.gn ('k') | components/ui_devtools/views/ui_devtools_dom_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ui_devtools/views/ui_devtools_dom_agent.h
diff --git a/components/ui_devtools/views/ui_devtools_dom_agent.h b/components/ui_devtools/views/ui_devtools_dom_agent.h
index cdd2382fd7ce1bccbf329c1d4fc36e39e19a3b6c..09787e3e541788af8e1ad7024ffd67811eaee8ea 100644
--- a/components/ui_devtools/views/ui_devtools_dom_agent.h
+++ b/components/ui_devtools/views/ui_devtools_dom_agent.h
@@ -6,6 +6,7 @@
#define COMPONENTS_UI_DEVTOOLS_VIEWS_UI_DEVTOOLS_DOM_AGENT_H_
#include "components/ui_devtools/DOM.h"
+#include "components/ui_devtools/Overlay.h"
#include "components/ui_devtools/devtools_base_agent.h"
#include "components/ui_devtools/views/ui_element_delegate.h"
#include "ui/aura/env_observer.h"
@@ -38,11 +39,11 @@ class UIDevToolsDOMAgent : public ui_devtools::UiDevToolsBaseAgent<
ui_devtools::protocol::Response disable() override;
ui_devtools::protocol::Response getDocument(
std::unique_ptr<ui_devtools::protocol::DOM::Node>* out_root) override;
- ui_devtools::protocol::Response highlightNode(
- std::unique_ptr<ui_devtools::protocol::DOM::HighlightConfig>
- highlight_config,
- ui_devtools::protocol::Maybe<int> node_id) override;
ui_devtools::protocol::Response hideHighlight() override;
+ ui_devtools::protocol::Response pushNodesByBackendIdsToFrontend(
+ std::unique_ptr<protocol::Array<int>> backend_node_ids,
+ std::unique_ptr<protocol::Array<int>>* result) override;
+ ui_devtools::protocol::Response setInspectedNode(int node_id) override;
// UIElementDelegate:
void OnUIElementAdded(UIElement* parent, UIElement* child) override;
@@ -57,6 +58,11 @@ class UIDevToolsDOMAgent : public ui_devtools::UiDevToolsBaseAgent<
const std::vector<aura::Window*>& root_windows() const {
return root_windows_;
};
+ ui_devtools::protocol::Response HighlightNode(
+ std::unique_ptr<ui_devtools::protocol::Overlay::HighlightConfig>
+ highlight_config,
+ int node_id);
+ void FindElementByEventHandler(const gfx::Point& p, int* element_id);
private:
// aura::EnvObserver:
@@ -78,14 +84,9 @@ class UIDevToolsDOMAgent : public ui_devtools::UiDevToolsBaseAgent<
views::View* view);
void RemoveDomNode(UIElement* ui_element);
void Reset();
- void InitializeHighlightingWidget();
void UpdateHighlight(
const std::pair<aura::Window*, gfx::Rect>& window_and_bounds,
SkColor background);
- ui_devtools::protocol::Response HighlightNode(
- std::unique_ptr<ui_devtools::protocol::DOM::HighlightConfig>
- highlight_config,
- int node_id);
bool is_building_tree_;
std::unique_ptr<UIElement> window_element_root_;
« no previous file with comments | « components/ui_devtools/views/BUILD.gn ('k') | components/ui_devtools/views/ui_devtools_dom_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698