Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2959193002: Disable baked-in popular sites for iOS. (Closed)

Created:
3 years, 5 months ago by fhorschig
Modified:
3 years, 5 months ago
Reviewers:
sfiera
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable baked-in popular sites for iOS. The launch of this feature has been postponed. As Finch does not guarantee that this feature is disabled, disable it in the code. (Reenabling this feature will happen after disabling was merged to M60). BUG=737607 Review-Url: https://codereview.chromium.org/2959193002 Cr-Commit-Position: refs/heads/master@{#483677} Committed: https://chromium.googlesource.com/chromium/src/+/61b617a08bebd805857faae0eaefed7315b5fdcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/ntp_tiles/popular_sites_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/popular_sites_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
fhorschig
Hi Chris, could you please take a look at this kill switch? To be merged ...
3 years, 5 months ago (2017-06-28 16:31:13 UTC) #4
sfiera
LGTM
3 years, 5 months ago (2017-06-29 09:16:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959193002/1
3 years, 5 months ago (2017-06-30 10:28:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/61b617a08bebd805857faae0eaefed7315b5fdcd
3 years, 5 months ago (2017-06-30 11:34:07 UTC) #12
fhorschig
3 years, 5 months ago (2017-06-30 16:21:56 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2962363002/ by fhorschig@chromium.org.

The reason for reverting is: Reverting the disabling makes baked-in popular
sites available on Dev/Canary M61+ again.

Disabling baked-in popular sites is only needed for M60. (50% Beta Approval is
given for M61 in issue 725961).

Powered by Google App Engine
This is Rietveld 408576698