Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2956303002: Reenable baked-in popular sites for iOS. (Closed)

Created:
3 years, 5 months ago by fhorschig
Modified:
3 years, 5 months ago
Reviewers:
sfiera
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable baked-in popular sites for iOS. This CL reenables baked-in popular sites feature which has been disabled for M60 only. BUG=737607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/ntp_tiles/popular_sites_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/popular_sites_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2959193002 Patch 1

Messages

Total messages: 5 (2 generated)
fhorschig
Hi Chris, would you please take a look at the anti-kill switch for https://codereview.chromium.org/2959193002/?
3 years, 5 months ago (2017-06-28 16:31:55 UTC) #2
sfiera
Can you instead revert 2959193002 immediately after it's submitted? You shouldn't need any approvals to ...
3 years, 5 months ago (2017-06-29 09:15:38 UTC) #3
fhorschig
3 years, 5 months ago (2017-06-30 16:02:32 UTC) #5
Message was sent while issue was closed. 
On 2017/06/29 09:15:38, sfiera wrote:
> Can you instead revert 2959193002 immediately after it's submitted? You
> shouldn't need any approvals to revert (or you are welcome to TBR to me), and
> that will look correct in the commit history.

Sgtm

Powered by Google App Engine
This is Rietveld 408576698