Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2958693002: Reland with a fix: Do not activate TrayBubbleView by default (Closed)

Created:
3 years, 6 months ago by yawano
Modified:
3 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, groby+bubble_chromium.org, sadrul, awdf+watch_chromium.org, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, hcarmona+bubble_chromium.org, kalyank, rouslan+bubble_chromium.org, dmazzoni, James Cook
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland with a fix: Do not activate TrayBubbleView by default - Activating a TrayBubbleView brings an Android window to onPause state. - This CL sets can_set_activate to false and makes TrayBubbleView not activated by default. - If the TrayBubbleView is not activated, it cannot capture key events for moving focus or closing the view by keyboard. TrayBubbleView tries to register accelerators at the global level to capture those key events. - Activates the TrayBubbleView by default if keyboard navigation accessibility feature (e.g. spoken feedback) is enabled. TBR=dmazzoni@chromium.org, jamescook@chromium.org BUG=726588, 731748 TEST=Follow steps described in the issue Review-Url: https://codereview.chromium.org/2897553002 Cr-Commit-Position: refs/heads/master@{#481421} Committed: https://chromium.googlesource.com/chromium/src/+/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c patch from issue 2897553002 at patchset 270001 (http://crrev.com/2897553002#ps270001) Review-Url: https://codereview.chromium.org/2958693002 Cr-Commit-Position: refs/heads/master@{#482490} Committed: https://chromium.googlesource.com/chromium/src/+/66c305b497c7f8e2125a05f544fd346862f0bb8e

Patch Set 1 #

Patch Set 2 : Add a fix. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -71 lines) Patch
M ash/system/ime_menu/ime_menu_tray.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M ash/system/palette/palette_tray.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/system/palette/palette_tray.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.h View 4 chunks +5 lines, -7 lines 0 comments Download
M ash/system/tray/system_tray.cc View 9 chunks +24 lines, -37 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 3 chunks +4 lines, -12 lines 1 comment Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 3 chunks +18 lines, -1 line 0 comments Download
M ui/message_center/views/message_bubble_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 6 chunks +32 lines, -3 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 7 chunks +87 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yawano
stevenjb@: PTAL. Thank you! TBRing dmazzoni@, jamescook@ https://codereview.chromium.org/2958693002/diff/20001/ash/system/tray/system_tray_bubble.cc File ash/system/tray/system_tray_bubble.cc (right): https://codereview.chromium.org/2958693002/diff/20001/ash/system/tray/system_tray_bubble.cc#newcode188 ash/system/tray/system_tray_bubble.cc:188: bubble_view_->UpdateBubble(); It ...
3 years, 6 months ago (2017-06-26 04:02:30 UTC) #6
stevenjb
lgtm
3 years, 5 months ago (2017-06-26 16:36:23 UTC) #9
yawano
On 2017/06/26 16:36:23, stevenjb wrote: > lgtm Thank you!
3 years, 5 months ago (2017-06-27 00:32:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958693002/20001
3 years, 5 months ago (2017-06-27 00:32:35 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 00:37:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66c305b497c7f8e2125a05f544fd...

Powered by Google App Engine
This is Rietveld 408576698