Reland with a fix: Do not activate TrayBubbleView by default

ash/system/tray/system_tray_bubble.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray_bubble.h"
 
 #include <utility>
 #include <vector>
 
 #include "ash/session/session_controller.h"
@@ skipping 66 matching lines @@
     : tray_(tray),
       bubble_view_(nullptr),
       items_(items),
       bubble_type_(bubble_type),
       autoclose_delay_(0) {}
 
 SystemTrayBubble::~SystemTrayBubble() {
   DestroyItemViews();
   // Reset the host pointer in bubble_view_ in case its destruction is deferred.
   if (bubble_view_)
-    bubble_view_->reset_delegate();
+    bubble_view_->ResetDelegate();
 }
 
 void SystemTrayBubble::UpdateView(
     const std::vector<ash::SystemTrayItem*>& items,
     BubbleType bubble_type) {
   std::unique_ptr<ui::Layer> scoped_layer;
   if (bubble_type != bubble_type_) {
     base::TimeDelta swipe_duration =
         base::TimeDelta::FromMilliseconds(kSwipeDelayMS);
     scoped_layer = bubble_view_->RecreateLayer();
@@ skipping 78 matching lines @@
         ui::ScopedLayerAnimationSettings settings(new_layer->GetAnimator());
         settings.AddObserver(
             new AnimationObserverDeleteLayer(scoped_layer.release()));
         settings.SetTransitionDuration(
             base::TimeDelta::FromMilliseconds(kSwipeDelayMS));
         settings.SetTweenType(gfx::Tween::EASE_OUT);
         new_layer->SetTransform(gfx::Transform());
       }
     }
   }
+
+  // Update bubble as size might have changed.
+  bubble_view_->UpdateBubble();

[yawano, 2017/06/26 04:02:30]

It is necessary to call here.

TrayBubbleView::UpdateBubble moves focus to the first focusable element if extra
keyboard accessibility is enabled.

SystemTray::ShowItems calls SystemTrayBubble::UpdateView if it reuses existing
view, e.g. opening bluetooth submenu in system tray.

For not-reusing existing view case, we are calling TrayBubbleView::UpdateBubble
in TrayBubbleView::InitializeAndShowBubble.

 }
 
 void SystemTrayBubble::InitView(views::View* anchor,
                                 LoginStatus login_status,
                                 TrayBubbleView::InitParams* init_params) {
   DCHECK(anchor);
   DCHECK(!bubble_view_);
 
   if (bubble_type_ == BUBBLE_TYPE_DETAILED &&
       init_params->max_height < GetDetailedBubbleMaxHeight()) {
     init_params->max_height = GetDetailedBubbleMaxHeight();
   }
 
   init_params->delegate = tray_;
   // Place the bubble on same display as this system tray.
   init_params->parent_window = tray_->GetBubbleWindowContainer();
   init_params->anchor_view = anchor;
   bubble_view_ = new TrayBubbleView(*init_params);
   UpdateBottomPadding();
   bubble_view_->set_adjust_if_offscreen(false);
   CreateItemViews(login_status);
 
   if (bubble_view_->CanActivate()) {
     bubble_view_->NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
   }
 }
 
-void SystemTrayBubble::FocusDefaultIfNeeded() {
-  views::FocusManager* manager = bubble_view_->GetFocusManager();
-  if (!manager || manager->GetFocusedView())
-    return;
-
-  views::View* view =
-      manager->GetNextFocusableView(nullptr, nullptr, false, false);
-  if (view)
-    view->RequestFocus();
-}
-
 void SystemTrayBubble::DestroyItemViews() {
   for (std::vector<ash::SystemTrayItem*>::iterator it = items_.begin();
        it != items_.end(); ++it) {
     switch (bubble_type_) {
       case BUBBLE_TYPE_DEFAULT:
         (*it)->OnDefaultViewDestroyed();
         break;
       case BUBBLE_TYPE_DETAILED:
         (*it)->OnDetailedViewDestroyed();
         break;
@@ skipping 100 matching lines @@
     }
   }
 
   if (focus_view) {
     tray_->ActivateBubble();
     focus_view->RequestFocus();
   }
 }
 
 }  // namespace ash