Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 2958653002: Fix string for single page print jobs. (Closed)

Created:
3 years, 6 months ago by skau
Modified:
3 years, 6 months ago
Reviewers:
xdai1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix string for single page print jobs. BUG=735083 Review-Url: https://codereview.chromium.org/2958653002 Cr-Commit-Position: refs/heads/master@{#482077} Committed: https://chromium.googlesource.com/chromium/src/+/3a88d1e835354dbc2ba14c67a74f521bd9605d2f

Patch Set 1 #

Patch Set 2 : fix base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printing/cups_print_job_notification.cc View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
skau
Please take a look. I hope you don't mind that I stole the bug.
3 years, 6 months ago (2017-06-23 23:02:02 UTC) #2
xdai1
On 2017/06/23 23:02:02, skau wrote: > Please take a look. I hope you don't mind ...
3 years, 6 months ago (2017-06-23 23:07:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958653002/20001
3 years, 6 months ago (2017-06-23 23:16:55 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 23:54:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a88d1e835354dbc2ba14c67a74f...

Powered by Google App Engine
This is Rietveld 408576698