Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: chrome/browser/chromeos/printing/cups_print_job_notification.cc

Issue 2958653002: Fix string for single page print jobs. (Closed)
Patch Set: fix base Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/printing/cups_print_job_notification.cc
diff --git a/chrome/browser/chromeos/printing/cups_print_job_notification.cc b/chrome/browser/chromeos/printing/cups_print_job_notification.cc
index f8158fe1363193f9e47ab4baa30c3c2c960e7b56..6216b8da3afc597837a818717809df0bdc4589a9 100644
--- a/chrome/browser/chromeos/printing/cups_print_job_notification.cc
+++ b/chrome/browser/chromeos/printing/cups_print_job_notification.cc
@@ -234,12 +234,17 @@ void CupsPrintJobNotification::UpdateNotificationIcon() {
}
void CupsPrintJobNotification::UpdateNotificationBodyMessage() {
- base::string16 message = l10n_util::GetStringFUTF16(
- (print_job_->total_page_number() > 1)
- ? IDS_PRINT_JOB_NOTIFICATION_MESSAGE
- : IDS_PRINT_JOB_NOTIFICATION_SINGLE_PAGE_MESSAGE,
- base::IntToString16(print_job_->total_page_number()),
- base::UTF8ToUTF16(print_job_->printer().display_name()));
+ base::string16 message;
+ if (print_job_->total_page_number() > 1) {
+ message = l10n_util::GetStringFUTF16(
+ IDS_PRINT_JOB_NOTIFICATION_MESSAGE,
+ base::IntToString16(print_job_->total_page_number()),
+ base::UTF8ToUTF16(print_job_->printer().display_name()));
+ } else {
+ message = l10n_util::GetStringFUTF16(
+ IDS_PRINT_JOB_NOTIFICATION_SINGLE_PAGE_MESSAGE,
+ base::UTF8ToUTF16(print_job_->printer().display_name()));
+ }
notification_->set_message(message);
}
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698