Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2958523002: Make Position::LastOffsetInNode() to take const Node& (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Position::LastOffsetInNode() to take const Node& This patch changes |Position::LastOffsetInNode()| to take |const Node&| instead of |Node*| for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2958523002 Cr-Commit-Position: refs/heads/master@{#482182} Committed: https://chromium.googlesource.com/chromium/src/+/c2c114e864c548aec0a64d31c27bfbbaf319ad43

Patch Set 1 : 2017-06-23T18:50:42 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 3 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL Including core/editing and core/html
3 years, 6 months ago (2017-06-23 11:39:06 UTC) #5
tkent
lgtm
3 years, 6 months ago (2017-06-25 23:39:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958523002/1
3 years, 6 months ago (2017-06-25 23:39:59 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-26 02:07:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2c114e864c548aec0a64d31c27b...

Powered by Google App Engine
This is Rietveld 408576698