third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2958523002: Make Position::LastOffsetInNode() to take const Node&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2958523002: Make Position::LastOffsetInNode() to take const Node& (Closed)

Patch Set: 2017-06-23T18:50:42 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index 3635296fc86f3c0389fc2a47d5afeae507785099..228be4f8b341c7635764382d9c5d12719c11391a 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -421,7 +421,8 @@ bool InsertListCommand::DoApplyForSingleParagraph(

if (range_start_is_in_list && new_list)

current_selection.setStart(new_list, 0, IGNORE_EXCEPTION_FOR_TESTING);

if (range_end_is_in_list && new_list) {

- current_selection.setEnd(new_list, Position::LastOffsetInNode(new_list),

+ current_selection.setEnd(new_list,

+ Position::LastOffsetInNode(*new_list),

IGNORE_EXCEPTION_FOR_TESTING);

}