Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2958193002: Device emulator: Replace usage of paper-dialog with cr-dialog. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Device emulator: Replace usage of paper-dialog with cr-dialog. BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2958193002 Cr-Commit-Position: refs/heads/master@{#483130} Committed: https://chromium.googlesource.com/chromium/src/+/e2373d1bfd089b71f03973452c764c65e0a3ce32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M chrome/browser/resources/chromeos/emulator/audio_settings.html View 3 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/emulator/audio_settings.js View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/emulator/bluetooth_settings.html View 3 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/emulator/bluetooth_settings.js View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/emulator/shared_styles.html View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
dpapad
Bluetooth dialog screenshots at http://imgur.com/a/9iWwc. Audio settings dialog screenshots at: http://imgur.com/a/32Nwv.
3 years, 5 months ago (2017-06-28 01:02:03 UTC) #5
michaelpg
lgtm Thank you for updating and testing this!
3 years, 5 months ago (2017-06-28 18:16:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958193002/1
3 years, 5 months ago (2017-06-28 20:49:29 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:56:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2373d1bfd089b71f03973452c76...

Powered by Google App Engine
This is Rietveld 408576698