Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2956003004: Polymer: Make paper-dialog resources ChromeOS only. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: Make paper-dialog resources ChromeOS only. The only remaining usages of paper-dialog are in ChromeOS. Until they are removed (in favor of cr-dialog), there is no reason to include them in other platfrorms. BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2956003004 Cr-Commit-Position: refs/heads/master@{#483126} Committed: https://chromium.googlesource.com/chromium/src/+/b9546a7a38d574646e91e92c12d9247378b5bb11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M ui/webui/resources/polymer_resources.grdp View 1 chunk +20 lines, -18 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dpapad
3 years, 5 months ago (2017-06-28 00:49:28 UTC) #5
stevenjb
lgtm
3 years, 5 months ago (2017-06-28 18:02:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956003004/1
3 years, 5 months ago (2017-06-28 20:40:47 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:45:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b9546a7a38d574646e91e92c12d9...

Powered by Google App Engine
This is Rietveld 408576698