Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2958173003:
[DevTools] Show ARIA pane based on whether AXNode is DOM node (Closed)
|
Created:
3 years, 5 months ago by aboxhall Modified:
3 years, 5 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, je_julie, dougt+watch_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, dmazzoni, dmazzoni+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionShow ARIA pane based on whether AXNode is DOM node, instead of based on whether it is ignored.
BUG=616950
Review-Url: https://codereview.chromium.org/2958173003
Cr-Commit-Position: refs/heads/master@{#483339}
Committed: https://chromium.googlesource.com/chromium/src/+/3691cc167a224f40ff2909dcf51193b93b244c0d
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (8 generated)
aboxhall@chromium.org changed reviewers: + lushnikov@chromium.org
Description was changed from ========== Show ARIA pane based on whether AXNode is DOM node BUG=616950 ========== to ========== Show ARIA pane based on whether AXNode is DOM node BUG=616950 ==========
https://codereview.chromium.org/2958173003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js (right): https://codereview.chromium.org/2958173003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js:55: if (axNode.isDOMNode()) What is "ignored" axNode? Should the condition be if (axNode.isDOMNode() && !axNode.ignored()) ...
https://codereview.chromium.org/2958173003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js (right): https://codereview.chromium.org/2958173003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js:55: if (axNode.isDOMNode()) On 2017/06/28 18:21:00, lushnikov wrote: > What is "ignored" axNode? Should the condition be > > if (axNode.isDOMNode() && !axNode.ignored()) > ... I deliberately removed that. Ignored means there is no AXNode, but ARIA can affect that so we should show the ARIA pane anyway.
Description was changed from ========== Show ARIA pane based on whether AXNode is DOM node BUG=616950 ========== to ========== Show ARIA pane based on whether AXNode is DOM node, instead of based on whether it is ignored. BUG=616950 ==========
thanks for clarifying, lgtm
The CQ bit was checked by aboxhall@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by aboxhall@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498734985868800, "parent_rev":
"55e83673a7fbafc0baa048c3e02e1fdcd86d08dc", "commit_rev":
"3691cc167a224f40ff2909dcf51193b93b244c0d"}
Message was sent while issue was closed.
Description was changed from ========== Show ARIA pane based on whether AXNode is DOM node, instead of based on whether it is ignored. BUG=616950 ========== to ========== Show ARIA pane based on whether AXNode is DOM node, instead of based on whether it is ignored. BUG=616950 Review-Url: https://codereview.chromium.org/2958173003 Cr-Commit-Position: refs/heads/master@{#483339} Committed: https://chromium.googlesource.com/chromium/src/+/3691cc167a224f40ff2909dcf511... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3691cc167a224f40ff2909dcf511... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
